Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove km from visibility, add visibility_distance #8454

Merged
merged 5 commits into from
Jul 14, 2017
Merged

Remove km from visibility, add visibility_distance #8454

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5fd6f0e
Remove km from visibility, add visibility_distance
gollo Jul 12, 2017
7d8f529
Fix line length
gollo Jul 12, 2017
106b9be
Fix trailing space and line break indentation
gollo Jul 12, 2017
433f3c0
Indentation
gollo Jul 12, 2017
09255c0
More whitespace
gollo Jul 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion homeassistant/components/sensor/metoffice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@
'exceptional': [],
}

VISIBILTY_CLASSES = {
'VP': '<1',
'PO': '1-4',
'MO': '4-10',
'GO': '10-20',
'VG': '20-40',
'EX': '>40'
}

SCAN_INTERVAL = timedelta(minutes=35)

# Sensor types are defined like: Name, units
Expand All @@ -51,7 +60,8 @@
'wind_speed': ['Wind Speed', 'm/s'],
'wind_direction': ['Wind Direction', None],
'wind_gust': ['Wind Gust', 'm/s'],
'visibility': ['Visibility', 'km'],
'visibility': ['Visibility', None],
'visibility_distance': ['Visibility Distance', 'km'],
'uv': ['UV', None],
'precipitation': ['Probability of Precipitation', '%'],
'humidity': ['Humidity', '%']
Expand Down Expand Up @@ -119,6 +129,14 @@ def name(self):
@property
def state(self):
"""Return the state of the sensor."""
"""
Special case for added visibility_distance
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

which is just a lookup on visibility code,
not retrieved from the dp call directly.
"""
if self._condition == "visibility_distance" \
and 'visibility' in self.data.data.__dict__.keys():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line over-indented for visual indent

return VISIBILTY_CLASSES.get(self.data.data.visibility.value)
if self._condition in self.data.data.__dict__.keys():
variable = getattr(self.data.data, self._condition)
if self._condition == "weather":
Expand Down