Remove km from visibility, add visibility_distance #8454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 12, 2017
| Special case for added visibility_distance which is just a lookup on visibility code, | ||
| not retrieved from the dp call directly. | ||
| """ | ||
| if self._condition == "visibility_distance" and 'visibility' in self.data.data.__dict__.keys(): |
There was a problem hiding this comment.
line too long (103 > 79 characters)
| @@ -119,6 +129,12 @@ def name(self): | |||
| @property | |||
| def state(self): | |||
| """Return the state of the sensor.""" | |||
| """ | |||
| Special case for added visibility_distance which is just a lookup on visibility code, | |||
There was a problem hiding this comment.
line too long (96 > 79 characters)
houndci-bot
reviewed
Jul 12, 2017
| not retrieved from the dp call directly. | ||
| """ | ||
| if self._condition == "visibility_distance" \ | ||
| and 'visibility' in self.data.data.__dict__.keys(): |
There was a problem hiding this comment.
continuation line over-indented for visual indent
| @@ -119,6 +129,14 @@ def name(self): | |||
| @property | |||
| def state(self): | |||
| """Return the state of the sensor.""" | |||
| """ | |||
| Special case for added visibility_distance | |||
houndci-bot
reviewed
Jul 12, 2017
| not retrieved from the dp call directly. | ||
| """ | ||
| if (self._condition == 'visibility_distance' and | ||
| 'visibility' in self.data.data.__dict__.keys()): |
There was a problem hiding this comment.
visually indented line with same indent as next logical line
| which is just a lookup on visibility code, | ||
| not retrieved from the dp call directly. | ||
| """ | ||
| if (self._condition == 'visibility_distance' and |
balloob
pushed a commit
that referenced
this pull request
Jul 16, 2017
* Remove km from visibility, add visibility_distance * Fix line length * Fix trailing space and line break indentation * Indentation * More whitespace
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Remove km from visibility, add visibility_distance * Fix line length * Fix trailing space and line break indentation * Indentation * More whitespace
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The values for visibility provided by the Met Office are not in km but are codes (VG=Very Good, etc). These then map to estimated distance ranges of visibility.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2968
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passNew dependencies have been added to theREQUIREMENTSvariable (example).New dependencies are only imported inside functions that use them (example).New dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.New files were added to.coveragerc.