Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tado climate device #8298

Merged
merged 1 commit into from
Jul 2, 2017
Merged

Tado climate device #8298

merged 1 commit into from
Jul 2, 2017

Conversation

wmalgadey
Copy link
Contributor

moved PyTado from my github repository to PyPi (PyTado2) as in regard to #7069.

PyTado2 is maintained by myself. The maintainer from PyTado could not be reached.

@mention-bot
Copy link

@wmalgadey, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @Teagan42 and @balloob to be potential reviewers.

@balloob
Copy link
Member

balloob commented Jul 2, 2017

  • Please create a new branch based off the latest dev for new PRs. This PR contains your old PR too.
  • I don't like the pytado2 name because it makes it sound like an official successor, which it is not. I would prefer python-tado to indicate that it's a fork (it can still be available inside python as pytado)

@wmalgadey
Copy link
Contributor Author

fabaff suggested the pyTado2 name in #8041!

What do you mean with

.. it can be available inside python as PyTado

Currently just the name of the package is PyTado2 the namespace is the same as before!

@balloob
Copy link
Member

balloob commented Jul 2, 2017

Yeah, I was talking about the namespace indeed. Good that it stays the same 👍

@wmalgadey
Copy link
Contributor Author

I don't really like pytado2 neither! I just pushed everything ;)

@wmalgadey
Copy link
Contributor Author

So! Changed the package on pypi and all my repositories (again ;))

@balloob
Copy link
Member

balloob commented Jul 2, 2017

Thank you very much! 🐬

@balloob balloob merged commit a2f5b63 into home-assistant:dev Jul 2, 2017
@balloob balloob mentioned this pull request Jul 13, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
@wmalgadey wmalgadey deleted the tado_climate_device branch March 10, 2019 11:40
@ghost ghost removed the platform: climate.tado label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants