Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pytest-aiohttp #82475

Merged
merged 10 commits into from
Nov 29, 2022
Merged

Upgrade pytest-aiohttp #82475

merged 10 commits into from
Nov 29, 2022

Commits on Nov 29, 2022

  1. Upgrade pytest-aiohttp

    @elupus
    elupus committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    ea78c09 View commit details
    Browse the repository at this point in the history

  2. Make sure executors, tasks and timers are closed 

    Some test will trigger warnings on garbage collect, these warnings
spills over into next test.

Some test trigger tasks that raise errors on shutdown, these spill
over into next test.

This is to mimic older pytest-aiohttp and it's behaviour on test
cleanup.

Discussions on similar changes for pytest-aiohttp are here:
pytest-dev/pytest-asyncio#309
    @elupus
    elupus committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    c47a210 View commit details
    Browse the repository at this point in the history

  3. Replace loop with event_loop

    @elupus
    elupus committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    72b5fca View commit details
    Browse the repository at this point in the history

  4. Make sure time is frozen for tests

    @elupus
    elupus committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    194c8c5 View commit details
    Browse the repository at this point in the history

  5. Make sure the ConditionType is not async 

      /home-assistant/homeassistant/helpers/template.py:2082: RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
    def wrapper(*args, **kwargs):
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.
    @elupus
    elupus committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    71b283f View commit details
    Browse the repository at this point in the history

  6. Increase litejet press tests with a factor 10 

    The times are simulated anyway, and we can't stop the normal
event from occuring.
    @elupus
    elupus committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    ef8df5a View commit details
    Browse the repository at this point in the history

  7. Use async handlers for aiohttp 

    tests/components/motioneye/test_camera.py::test_get_still_image_from_camera
tests/components/motioneye/test_camera.py::test_get_still_image_from_camera
tests/components/motioneye/test_camera.py::test_get_stream_from_camera
tests/components/motioneye/test_camera.py::test_get_stream_from_camera
tests/components/motioneye/test_camera.py::test_camera_option_stream_url_template
tests/components/motioneye/test_camera.py::test_camera_option_stream_url_template
  /Users/joakim/src/hass/home-assistant/venv/lib/python3.9/site-packages/aiohttp/web_urldispatcher.py:189: DeprecationWarning: Bare functions are deprecated, use async ones
    warnings.warn(
    @elupus
    elupus committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b162712 View commit details
    Browse the repository at this point in the history

  8. Switch to freezegun in modbus tests 

    The tests allowed clock to tick in between steps
    @elupus
    elupus committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    2a208d0 View commit details
    Browse the repository at this point in the history

  9. Make sure skybell object are fully mocked 

    Old tests would trigger attempts to post to could services:

```
DEBUG:aioskybell:HTTP post https://cloud.myskybell.com/api/v3/login/ Request with headers: {'content-type': 'application/json', 'accept': '*/*', 'x-skybell-app-id': 'd2b542c7-a7e4-4e1e-b77d-2b76911c7c46', 'x-skybell-client-id': '1f36a3c0-6dee-4997-a6db-4e1c67338e57'}
```
    @elupus
    elupus committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f8ff685 View commit details
    Browse the repository at this point in the history

  10. Fix sorting that broke after rebase

    @elupus
    elupus committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f48843a View commit details
    Browse the repository at this point in the history