Upgrade pytest-aiohttp #82475
Merged
Upgrade pytest-aiohttp #82475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
core
small-pr
elupus
force-pushed
the
pytest/asyncio
branch
from
2c1f3fd
to
c07b5e8
Compare
bdraco
reviewed
Nov 21, 2022
elupus
force-pushed
the
pytest/asyncio
branch
2 times, most recently
from
cb60dbf
to
739c17a
Compare
elupus
force-pushed
the
pytest/asyncio
branch
6 times, most recently
from
4d1335f
to
7605ce5
Compare
elupus
requested review from
ludeeus,
a team,
allenporter,
janiversen and
ochlocracy
as code owners
bdraco
approved these changes
Nov 27, 2022
elupus
commented
Nov 27, 2022
| """Freeze clock for tests.""" | ||
| yield | ||
|
|
||
|
|
There was a problem hiding this comment.
A bit unclear if this is needed after the garbage collect change. But i still think it make sense.
elupus
commented
Nov 27, 2022
| yield | ||
|
|
||
| event_loop.run_until_complete(event_loop.shutdown_default_executor()) | ||
|
|
There was a problem hiding this comment.
If we could ignore the executor threads easily in the below threads check, we dont need to stop these here.
Some test will trigger warnings on garbage collect, these warnings spills over into next test. Some test trigger tasks that raise errors on shutdown, these spill over into next test. This is to mimic older pytest-aiohttp and it's behaviour on test cleanup. Discussions on similar changes for pytest-aiohttp are here: pytest-dev/pytest-asyncio#309
/home-assistant/homeassistant/helpers/template.py:2082: RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
def wrapper(*args, **kwargs):
Enable tracemalloc to get traceback where the object was allocated.
See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.
The times are simulated anyway, and we can't stop the normal event from occuring.
tests/components/motioneye/test_camera.py::test_get_still_image_from_camera
tests/components/motioneye/test_camera.py::test_get_still_image_from_camera
tests/components/motioneye/test_camera.py::test_get_stream_from_camera
tests/components/motioneye/test_camera.py::test_get_stream_from_camera
tests/components/motioneye/test_camera.py::test_camera_option_stream_url_template
tests/components/motioneye/test_camera.py::test_camera_option_stream_url_template
/Users/joakim/src/hass/home-assistant/venv/lib/python3.9/site-packages/aiohttp/web_urldispatcher.py:189: DeprecationWarning: Bare functions are deprecated, use async ones
warnings.warn(
The tests allowed clock to tick in between steps
Old tests would trigger attempts to post to could services: ``` DEBUG:aioskybell:HTTP post https://cloud.myskybell.com/api/v3/login/ Request with headers: {'content-type': 'application/json', 'accept': '*/*', 'x-skybell-app-id': 'd2b542c7-a7e4-4e1e-b77d-2b76911c7c46', 'x-skybell-client-id': '1f36a3c0-6dee-4997-a6db-4e1c67338e57'} ```
elupus
force-pushed
the
pytest/asyncio
branch
from
d89dcf2
to
f8ff685
Compare
jbouwh
approved these changes
Nov 29, 2022
| # before moving on to the next test. | ||
| tasks = asyncio.all_tasks(event_loop) - tasks_before | ||
| for task in tasks: | ||
| warnings.warn(f"Linger task after test {task}") |
| handle.cancel() | ||
|
|
||
| # Make sure garbage collect run in same test as allocation | ||
| # this is to mimic the behavior of pytest-aiohttp, and is |
There was a problem hiding this comment.
Start a new sentence on this line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Attempt to bump pytest-aiohttp
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: