Add details to triggered state for total connect alarms #24106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to latest HA
it is a burglar or fire or carbon monoxide so automations can take appropriate actions. Updated TotalConnect component to handle these new states.
Also bumps total_connect_client to 0.27.
homeassistant
added
integration: totalconnect
small-pr
austinmroczek
added a commit
to austinmroczek/home-assistant.github.io
that referenced
this pull request
May 25, 2019
Adds detail on the trigger source. See home-assistant/core#24106
1 task
balloob
reviewed
May 29, 2019
| @@ -59,9 +59,15 @@ def state(self): | |||
| """Return the state of the device.""" | |||
| return self._state | |||
|
|
|||
| @property | |||
| def state_attributes(self): | |||
There was a problem hiding this comment.
You are not allowed to implement state_attributes. Implement device_state_attributes instead.
There was a problem hiding this comment.
Updated to device_state_attributes
balloob
approved these changes
May 29, 2019
Merged
frenck
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Jun 29, 2019
Adds detail on the trigger source. See home-assistant/core#24106
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
…nt#24106) * Bump skybellpy to 0.4.0 * Bump skybellpy to 0.4.0 in requirements_all.txt * Added extra states for STATE_ALARM_TRIGGERED to allow users to know if it is a burglar or fire or carbon monoxide so automations can take appropriate actions. Updated TotalConnect component to handle these new states. * Fix const import * Fix const import * Fix const imports * Bump total-connect-client to 0.26. * Catch details of alarm trigger in state attributes. Also bumps total_connect_client to 0.27. * Change state_attributes() to device_state_attributes()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update to totalconnect component allows it to handle "triggered" state and provide detail such as police, fire or carbon monoxide.
Related issue (if applicable):
Per discussion at home-assistant/architecture#231
Pull request with documentation for home-assistant.io (if applicable):
home-assistant/home-assistant.io#9517
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.