Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMHI weather component not showing correct values in current forecast #17783

Merged
merged 5 commits into from
Oct 25, 2018
Merged

SMHI weather component not showing correct values in current forecast #17783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3baf180
fixes not showing current forecast correctly
helto4real Oct 25, 2018
84871bf
Update config_flow.py
balloob Oct 25, 2018
6d57815
Update smhi.py
balloob Oct 25, 2018
8c84507
Update requirements_all.txt
balloob Oct 25, 2018
155c462
Update requirements_test_all.txt
balloob Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/smhi/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from .config_flow import smhi_locations # noqa: F401
from .const import DOMAIN # noqa: F401

REQUIREMENTS = ['smhi-pkg==1.0.4']
REQUIREMENTS = ['smhi-pkg==1.0.5']

DEFAULT_NAME = 'smhi'

Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/smhi/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

from .const import DOMAIN, HOME_LOCATION_NAME

REQUIREMENTS = ['smhi-pkg==1.0.4']
REQUIREMENTS = ['smhi-pkg==1.0.5']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config flow shouldn't have requirements.

Copy link
Contributor Author

@helto4real helto4real Oct 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is harder since I use the component to validate input. I will have to find another way to do this. But now when I think about it we dont want dependencies here. I will fix it tonight before we release 0.81



@callback
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/weather/smhi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
ENTITY_ID_SENSOR_FORMAT, ATTR_SMHI_CLOUDINESS)

DEPENDENCIES = ['smhi']
REQUIREMENTS = ['smhi-pkg==1.0.4']
REQUIREMENTS = ['smhi-pkg==1.0.5']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform shouldn't have requirement, it is done through dependency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this one I should just remove


_LOGGER = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1385,7 +1385,7 @@ smappy==0.2.16
# homeassistant.components.smhi
# homeassistant.components.smhi.config_flow
# homeassistant.components.weather.smhi
smhi-pkg==1.0.4
smhi-pkg==1.0.5

# homeassistant.components.media_player.snapcast
snapcast==2.0.9
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ sleepyq==0.6
# homeassistant.components.smhi
# homeassistant.components.smhi.config_flow
# homeassistant.components.weather.smhi
smhi-pkg==1.0.4
smhi-pkg==1.0.5

# homeassistant.components.climate.honeywell
somecomfort==0.5.2
Expand Down