SMHI weather component not showing correct values in current forecast #17783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: smhi
platform: weather.smhi
small-pr
ghost
added
the
balloob
reviewed
Oct 25, 2018
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| from .const import DOMAIN, HOME_LOCATION_NAME | |||
|
|
|||
| REQUIREMENTS = ['smhi-pkg==1.0.4'] | |||
| REQUIREMENTS = ['smhi-pkg==1.0.5'] | |||
There was a problem hiding this comment.
config flow shouldn't have requirements.
There was a problem hiding this comment.
This one is harder since I use the component to validate input. I will have to find another way to do this. But now when I think about it we dont want dependencies here. I will fix it tonight before we release 0.81
balloob
reviewed
Oct 25, 2018
| @@ -30,7 +30,7 @@ | |||
| ENTITY_ID_SENSOR_FORMAT, ATTR_SMHI_CLOUDINESS) | |||
|
|
|||
| DEPENDENCIES = ['smhi'] | |||
| REQUIREMENTS = ['smhi-pkg==1.0.4'] | |||
| REQUIREMENTS = ['smhi-pkg==1.0.5'] | |||
There was a problem hiding this comment.
platform shouldn't have requirement, it is done through dependency
There was a problem hiding this comment.
ok this one I should just remove
balloob
approved these changes
Oct 25, 2018
balloob
pushed a commit
that referenced
this pull request
Oct 26, 2018
…#17783) * fixes not showing current forecast correctly * Update config_flow.py * Update smhi.py * Update requirements_all.txt * Update requirements_test_all.txt
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In some cases the Swedish weather forecast lib not returning correct forecast for the current value
Fix: new lib version 1.0.5
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: