Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump denonavr to v1.0.1 #131882

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Bump denonavr to v1.0.1 #131882

merged 1 commit into from
Nov 30, 2024

Conversation

ol-iver
Copy link
Contributor

@ol-iver ol-iver commented Nov 28, 2024

Proposed change

This PR updates denonavr library to v1.0.1 (changelog).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (denonavr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of denonavr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign denonavr Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco added this to the 2024.12.0 milestone Nov 28, 2024
@bdraco
Copy link
Member

bdraco commented Nov 28, 2024

I noticed ol-iver/denonavr#314 in the changelog.

If you want to avoid storing self in the lru_cache, lru-dict might be a cleaner option.

@ol-iver
Copy link
Contributor Author

ol-iver commented Nov 29, 2024

Thanks, I'm happy with the current state. I wanted to achieve that the garbage collector is able to collect old instances when their cache is populated. That's working now 🙂

@epenet epenet changed the title Update denonavr to v1.0.1 Bump denonavr to v1.0.1 Nov 29, 2024
@deiger
Copy link
Contributor

deiger commented Nov 29, 2024

@bdraco, this bump also includes the fix to the memory leak we triaged a couple of weeks ago.

@bdraco bdraco merged commit bd29aaf into home-assistant:dev Nov 30, 2024
65 checks passed
@bdraco
Copy link
Member

bdraco commented Nov 30, 2024

Thanks @ol-iver

balloob pushed a commit that referenced this pull request Dec 1, 2024
zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Dec 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Denon AVR Sound Mode mismatch between HA and the actual unit
5 participants