Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denon AVR Sound Mode mismatch between HA and the actual unit #121792

Closed
SodaWithoutSparkles opened this issue Jul 11, 2024 · 5 comments · Fixed by #131882
Closed

Denon AVR Sound Mode mismatch between HA and the actual unit #121792

SodaWithoutSparkles opened this issue Jul 11, 2024 · 5 comments · Fixed by #131882
Assignees

Comments

@SodaWithoutSparkles
Copy link

The problem

When using the "Denon AVR network recievers" integration with my AVR_X1600H, I discovered the following issue:

  • Sound mode status de-sync when operating via UI

Method to reproduce:

  1. turn on the reciever and select DTS NEU:X as sound mode with IR remote
  2. via developer tools/service, call media_player.select_sound_mode on the unit with "DOLBY DIGITAL" as sound mode, observe that the unit actually changed to DSUR mode
  3. observe that the state attribute of the unit changes to:
sound_mode: DOLBY DIGITAL
sound_mode_raw: DOLBY AUDIO-DSUR
  1. select "DTS SURROUND" via the UI, notice the unit actually changes to DTS Neu:X mode
  2. observe that the state attribute of the unit changes to:
sound_mode: DOLBY DIGITAL     <--- mismatch
sound_mode_raw: NEURAL:X
  1. close the dialogue box on the UI and re-open it, observe the sound mode is still stuck at "DOLBY DIGITAL"

What version of Home Assistant Core has the issue?

core-2024.7.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Denon AVR network recievers

Link to integration documentation on our website

https://www.home-assistant.io/integrations/denonavr/

Diagnostics information

It does not provide diagnostic

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.components.denonavr.media_player
Source: components/denonavr/media_player.py:213
integration: Denon AVR Network Receivers (documentation, issues)
First occurred: July 11, 2024 at 10:02:36 PM (3 occurrences)
Last logged: July 11, 2024 at 10:35:41 PM

Denon AVR receiver at host 192.168.31.36 responded with HTTP 403 error. Device is unavailable. Please consider power cycling your receiver

Additional information

A reload does not fix the issue, so the 403 is likely not an issue.

Possibily related to #117255 , but I cannot find the relevant logs.

It is possible to transition from DTS-STEREO-DOLBY, but the sound mode is still wrong.

It is not possible to transition from DTS-DOLBY directly as it thinks it was in DOLBY already.

@home-assistant
Copy link

Hey there @ol-iver, @starkillerOG, mind taking a look at this issue as it has been labeled with an integration (denonavr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of denonavr can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign denonavr Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


denonavr documentation
denonavr source
(message by IssueLinks)

@SodaWithoutSparkles
Copy link
Author

From my limited tests, I think the issue is incorrect mapping of NEURAL:X to DOLBY DIGITAL.

I will look through the code and see if I find anything

@SodaWithoutSparkles
Copy link
Author

SodaWithoutSparkles commented Jul 11, 2024

It seems that it was incorrectly mapped here. I can't find Dolby Neural:X on my unit, perhaps it would be unit-dependent?

https://github.com/ol-iver/denonavr/blob/a32de5979a4bda19e1e9b599fd895570af59e292/denonavr/const.py#L238-L249

Maybe it would be more approiate to check for NEURAL:X instead of DTS NEURAL:X?

https://github.com/ol-iver/denonavr/blob/a32de5979a4bda19e1e9b599fd895570af59e292/denonavr/const.py#L275-L279

Edit: sorry cant get the embedded code snippets to work

@SodaWithoutSparkles SodaWithoutSparkles changed the title Denon AVR Sound Mode status de-sync when using UI, but not when using services Denon AVR Sound Mode mismatch between HA and the actual unit Jul 11, 2024
@SodaWithoutSparkles
Copy link
Author

SodaWithoutSparkles commented Sep 25, 2024

Further testing will be needed to see if this have been solved by #126703

@ol-iver
Copy link
Contributor

ol-iver commented Nov 23, 2024

We made the wrong assumption where NEURAL:X belongs to 🙂
I fixed this with ol-iver/denonavr#317.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants