-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update denonavr
to v1.0.0
#126703
Update denonavr
to v1.0.0
#126703
Conversation
Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with Marantz NR1711 👍
Thanks @ol-iver
We set `update_before_add=True` anyway which also performs the query. Additionally, the removed call could cause an uncaught exception, e.g. on timeouts.
0f056f5
to
e7f379b
Compare
CI error isn't related, I'll go ahead with the merge. |
Proposed change
This PR updates
denonavr
library tov1.0.0
(changelog).Additionally, it removes an duplicate query to the receiver during
async_setup_entry
. It is not required, because the receiver entities are added withupdate_before_add=True
which performs the same query too.The removed query could also cause uncaught exceptions, e.g. on timeouts.
Finally, all configured zones are updated before telnet is connected, because the telnet connection affects all zones.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: