-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generic thermostat strings for clarity and accuracy #130243
Update generic thermostat strings for clarity and accuracy #130243
Conversation
If you prefix all the issues that should be closed with merging this, make sure you note them as |
What is the appropriate terminology for if it fixes only one of the things listed in the issue? |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
keep alive cannot be set from the config flow, so it is confusing to keep here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @maxshcherbina 👍
../Frenck
Proposed change
Per #130030, I removed "helper" from the title for consistency.
Per #128341, Updated the grammar on
target_sensor
.On
min_cycle_duration
, I changed thekeep_alive
option to make it more clear that it is a YAML only option. This addresses #128732.I will work on #128109 next, but as its a larger change, I didnt want to include it in this PR.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: