Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic thermostat strings for clarity and accuracy #130243

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

maxshcherbina
Copy link
Contributor

@maxshcherbina maxshcherbina commented Nov 9, 2024

Proposed change

Per #130030, I removed "helper" from the title for consistency.
Per #128341, Updated the grammar on target_sensor.
On min_cycle_duration, I changed the keep_alive option to make it more clear that it is a YAML only option. This addresses #128732.

I will work on #128109 next, but as its a larger change, I didnt want to include it in this PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

joostlek commented Nov 9, 2024

If you prefix all the issues that should be closed with merging this, make sure you note them as fixes #123

@maxshcherbina
Copy link
Contributor Author

maxshcherbina commented Nov 9, 2024

If you prefix all the issues that should be closed with merging this, make sure you note them as fixes #123

What is the appropriate terminology for if it fixes only one of the things listed in the issue?
In any case, fixed the prefixes!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 10, 2024 10:27
@maxshcherbina maxshcherbina marked this pull request as ready for review November 10, 2024 20:32
@home-assistant home-assistant bot requested a review from frenck November 10, 2024 20:32
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maxshcherbina 👍

../Frenck

@frenck frenck added this to the 2024.11.2 milestone Nov 10, 2024
@frenck frenck merged commit d7f41ff into home-assistant:dev Nov 10, 2024
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.