Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Thermostat: Several strings to clean up #130030

Closed
NoRi2909 opened this issue Nov 7, 2024 · 1 comment · Fixed by #130243
Closed

Generic Thermostat: Several strings to clean up #130030

NoRi2909 opened this issue Nov 7, 2024 · 1 comment · Fixed by #130243

Comments

@NoRi2909
Copy link
Contributor

NoRi2909 commented Nov 7, 2024

The problem

When adding a Generic Thermostat as a helper the word "helper" is repeated in the headline which is inconsistent with other helpers, specifically the Generic Hygrostat. This was already reported as part of #128109 :

image

This is contained here:

"title": "Add generic thermostat helper",

Should be removed as is gets quite crammed in translations, too.

In addition there is still a typo, already reported in #128341 , in

"target_sensor": "Temperature sensor that reflect the current temperature.",

Should be

 … reflects …

And finally there is still the misleading reference to the keep_alive option, already reported in #128732 , that needs to be fixed in

"min_cycle_duration": "Set a minimum amount of time that the switch specified must be in its current state prior to being switched either off or on. This option will be ignored if the keep alive option is set.",

by replacing this with

'keep_alive'

so the user does not search this in the dialog.

What version of Home Assistant Core has the issue?

core-2024.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant