Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source mapping in Onkyo #129716

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

arturpragacz
Copy link
Contributor

Proposed change

Fix for #129589. Please merge into beta.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@arturpragacz arturpragacz marked this pull request as ready for review November 4, 2024 23:18
@arturpragacz
Copy link
Contributor Author

I wasn't home, so couldn't test it with a real device, that is why the PR was a draft.
Now that I'm back, and I checked that it works fine, it's ready for merge.

@balloob balloob added this to the 2024.11.0 milestone Nov 5, 2024
@balloob balloob merged commit 617e87e into home-assistant:dev Nov 5, 2024
31 of 32 checks passed
balloob pushed a commit that referenced this pull request Nov 5, 2024
* Fix source mapping

* Fix copy paste
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@arturpragacz arturpragacz deleted the onkyo/fix-source-mapping branch November 7, 2024 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing source options in Onkyo integration
3 participants