Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing source options in Onkyo integration #129589

Closed
Thomas55555 opened this issue Oct 31, 2024 · 3 comments · Fixed by #129716
Closed

Missing source options in Onkyo integration #129589

Thomas55555 opened this issue Oct 31, 2024 · 3 comments · Fixed by #129716

Comments

@Thomas55555
Copy link
Contributor

The problem

Previously I had a yaml configuration for onkyo, which is now removed:
After the update to 2024.11.0b0 I got an error on start-up (see description)
I cant select select "TV" anymore as source.

What version of Home Assistant Core has the issue?

core-2024.11.0b0

What was the last working version of Home Assistant Core?

core-2024.10.3

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Onyko

Link to integration documentation on our website

https://rc.home-assistant.io/integrations/onkyo

Diagnostics information

No response

Example YAML snippet

media_player:
  - platform: onkyo
    name: receiver
    host: 192.168.178.22
    receiver_max_volume: 200
    sources:
      tv/tape: "TV"
      dab: "DAB"
      net: "Chromecast"

Anything in the logs that might be useful for us?

2024-10-31 18:05:52.986 ERROR (MainThread) [homeassistant] Error doing job: Exception in callback Receiver.async_create.<locals>.on_update(('main', 'input-selector', ('tape-1', 'tv/tape')), '192.168.178.22') at /usr/src/homeassistant/homeassistant/components/onkyo/receiver.py:50 (None)
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/src/homeassistant/homeassistant/components/onkyo/receiver.py", line 52, in on_update
    receiver.on_update(message)
  File "/usr/src/homeassistant/homeassistant/components/onkyo/receiver.py", line 91, in on_update
    callback(self, message)
  File "/usr/src/homeassistant/homeassistant/components/onkyo/media_player.py", line 288, in update_callback
    entity.process_update(message)
  File "/usr/src/homeassistant/homeassistant/components/onkyo/media_player.py", line 486, in process_update
    self._parse_source(value)
  File "/usr/src/homeassistant/homeassistant/components/onkyo/media_player.py", line 508, in _parse_source
    source = self._lib_mapping[source_lib]
             ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
KeyError: ('tape-1', 'tv/tape')

Additional information

No response

@home-assistant
Copy link

Hey there @arturpragacz, mind taking a look at this issue as it has been labeled with an integration (onkyo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of onkyo can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign onkyo Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


onkyo documentation
onkyo source
(message by IssueLinks)

@joostlek joostlek added this to the 2024.11.0 milestone Nov 1, 2024
@cdwertmann
Copy link

On Home Assistant 2024.11, I can no longer select the "CD" source on my TX-NR686.

@arturpragacz
Copy link
Contributor

@cdwertmann This issue is already closed. If you have some new problem, make a separate issue for it with all the necessary details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants