Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohasupervisor to version 0.2.1 #129574

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Bump aiohasupervisor to version 0.2.1 #129574

merged 3 commits into from
Oct 31, 2024

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Oct 31, 2024

Proposed change

Bump aiohasupervisor from version 0.2.0 to version 0.2.1, and fix type violations uncovered by the new version

Release notes: https://github.com/home-assistant-libs/python-supervisor-client/releases/tag/0.2.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet mentioned this pull request Oct 31, 2024
19 tasks
@emontnemery emontnemery added this to the 2024.11.0 milestone Oct 31, 2024
@MartinHjelmare
Copy link
Member

Some hassio tests are failing.

@MartinHjelmare MartinHjelmare marked this pull request as draft October 31, 2024 14:44
@emontnemery emontnemery marked this pull request as ready for review October 31, 2024 16:12
),
# Matching discovery key
(
"mock-domain",
{
"hassio": (DiscoveryKey(domain="hassio", key="test", version=1),),
"hassio": (DiscoveryKey(domain="hassio", key=TEST_UUID, version=1),),
"other": (DiscoveryKey(domain="other", key="blah", version=1),),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if key is an UUID, should we make sure this is also an UUID here?

@joostlek joostlek merged commit b09e54c into dev Oct 31, 2024
42 checks passed
@joostlek joostlek deleted the bump_aiohasupervisor_021 branch October 31, 2024 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants