Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringify discovered hassio uuid #129572

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Oct 31, 2024

Proposed change

Stringify discovered hassio uuid

The UUID received from aiohasupervisor is a UUID object, but the uuid in HassioServiceInfo is a str

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@emontnemery emontnemery added this to the 2024.11.0 milestone Oct 31, 2024
@epenet
Copy link
Contributor

epenet commented Oct 31, 2024

The corresponding tests need adjusting: tests/components/hassio/test_discovery.py

@epenet
Copy link
Contributor

epenet commented Oct 31, 2024

Fixes #129522

@epenet epenet linked an issue Oct 31, 2024 that may be closed by this pull request
@epenet
Copy link
Contributor

epenet commented Oct 31, 2024

Test failure unrelated: #129571

@epenet
Copy link
Contributor

epenet commented Oct 31, 2024

Do we want to consider the other mypy failures from #129574?

Python 3.12.7
Error: homeassistant/components/hassio/handler.py:385: error: Argument 1 to "SupervisorClient" has incompatible type "URL"; expected "str"  [arg-type]
Error: homeassistant/components/hassio/discovery.py:89: error: Argument 1 to "get" of "DiscoveryClient" has incompatible type "str"; expected "UUID"  [arg-type]
Error: homeassistant/components/hassio/discovery.py:107: error: Argument 1 to "get" of "DiscoveryClient" has incompatible type "str"; expected "UUID"  [arg-type]
Error: homeassistant/components/hassio/discovery.py:133: error: Argument "uuid" to "HassioServiceInfo" has incompatible type "UUID"; expected "str"  [arg-type]
Error: homeassistant/components/hassio/discovery.py:137: error: Argument "key" to "DiscoveryKey" has incompatible type "UUID"; expected "str | tuple[str, ...]"  [arg-type]
Error: homeassistant/components/hassio/discovery.py:149: error: Incompatible types in assignment (expression has type "Discovery", variable has type "dict[str, Any]")  [assignment]
Error: homeassistant/components/hassio/discovery.py:149: error: Argument 1 to "get" of "DiscoveryClient" has incompatible type "str"; expected "UUID"  [arg-type]

@emontnemery
Copy link
Contributor Author

Do we want to consider the other mypy failures from #129574?

Python 3.12.7
Error: homeassistant/components/hassio/handler.py:385: error: Argument 1 to "SupervisorClient" has incompatible type "URL"; expected "str"  [arg-type]
Error: homeassistant/components/hassio/discovery.py:89: error: Argument 1 to "get" of "DiscoveryClient" has incompatible type "str"; expected "UUID"  [arg-type]
Error: homeassistant/components/hassio/discovery.py:107: error: Argument 1 to "get" of "DiscoveryClient" has incompatible type "str"; expected "UUID"  [arg-type]
Error: homeassistant/components/hassio/discovery.py:133: error: Argument "uuid" to "HassioServiceInfo" has incompatible type "UUID"; expected "str"  [arg-type]
Error: homeassistant/components/hassio/discovery.py:137: error: Argument "key" to "DiscoveryKey" has incompatible type "UUID"; expected "str | tuple[str, ...]"  [arg-type]
Error: homeassistant/components/hassio/discovery.py:149: error: Incompatible types in assignment (expression has type "Discovery", variable has type "dict[str, Any]")  [assignment]
Error: homeassistant/components/hassio/discovery.py:149: error: Argument 1 to "get" of "DiscoveryClient" has incompatible type "str"; expected "UUID"  [arg-type]

Not in this PR

@emontnemery emontnemery merged commit 8eaec56 into dev Oct 31, 2024
41 of 42 checks passed
@emontnemery emontnemery deleted the hassio_stringify_discovered_uuid branch October 31, 2024 12:54
bramkragten pushed a commit that referenced this pull request Oct 31, 2024
* Stringify discovered hassio uuid

* Correct DiscoveryKey

* Adjust tests
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid unique ID OpenWakeWord, Piper, Wymonig, and whisper
4 participants