Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix songpal crash for soundbars without sound modes #119999

Merged

Conversation

BestPig
Copy link
Contributor

@BestPig BestPig commented Jun 19, 2024

Proposed change

Getting soundField on soundbar that doesn't support it crash raise an exception, so it make the whole components unavailable. As there is no simple way to know if soundField is supported, I just get all sound settings, and then pick soundField one if present. If not present, then return None to make it continue, it will just have to effect to display no sound mode and not able to select one (Exactly what we want).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rytilahti, @shenxn, mind taking a look at this pull request as it has been labeled with an integration (songpal) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of songpal can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign songpal Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@BestPig BestPig force-pushed the fix/crash-when-soundfield-unavailable branch from 32cebb9 to 00e44c1 Compare June 19, 2024 22:28
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @BestPig! 👍

Btw, would you mind checking what information we could use for diagnostics platform? This is not currently implemented, but is a requirement for gold level integrations (ref #117576).

@rytilahti rytilahti changed the title Fix crash for soundbar that don't have different sound modes available Fix songpal crash for soundbars without sound modes Jun 20, 2024
@rytilahti rytilahti merged commit 7c5fcec into home-assistant:dev Jun 20, 2024
24 checks passed
@rytilahti rytilahti added this to the 2024.6.4 milestone Jun 20, 2024
@BestPig
Copy link
Contributor Author

BestPig commented Jun 20, 2024

LGTM, thanks @BestPig! 👍

Btw, would you mind checking what information we could use for diagnostics platform? This is not currently implemented, but is a requirement for gold level integrations (ref #117576).

I can take a look at it, but probably during the next month if there is not hurry.

@rytilahti
Copy link
Member

I can take a look at it, but probably during the next month if there is not hurry.

Sure thing, no hurries :-)

@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Songpal unavailable due getSoundSettings: [1, 'server internal error']
3 participants