Gold and platinum integrations should implement diagnostic #117576

epenet · 2024-05-16T15:39:30Z

home-assistant · 2024-05-16T15:39:33Z

Hey there @fredrike, mind taking a look at this issue as it has been labeled with an integration (point) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of point can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign point Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

point documentation
point source
_{^{(message by IssueLinks)}}

home-assistant · 2024-05-16T15:39:33Z

Hey there @fredrike, mind taking a look at this issue as it has been labeled with an integration (tellduslive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tellduslive can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign tellduslive Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

tellduslive documentation
tellduslive source
_{^{(message by IssueLinks)}}

home-assistant · 2024-05-16T15:39:33Z

Hey there @janiversen, mind taking a look at this issue as it has been labeled with an integration (modbus) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of modbus can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign modbus Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

modbus documentation
modbus source
_{^{(message by IssueLinks)}}

home-assistant · 2024-05-16T15:39:34Z

Hey there @dermotduffy, mind taking a look at this issue as it has been labeled with an integration (hyperion) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hyperion can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign hyperion Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

hyperion documentation
hyperion source
_{^{(message by IssueLinks)}}

home-assistant · 2024-05-16T15:39:34Z

Hey there @mdz, mind taking a look at this issue as it has been labeled with an integration (smarttub) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of smarttub can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign smarttub Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

smarttub documentation
smarttub source
_{^{(message by IssueLinks)}}

home-assistant · 2024-05-16T15:39:34Z

Hey there @OnFreund, mind taking a look at this issue as it has been labeled with an integration (risco) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of risco can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign risco Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

risco documentation
risco source
_{^{(message by IssueLinks)}}

home-assistant · 2024-05-16T15:39:34Z

Hey there @rytilahti, @shenxn, mind taking a look at this issue as it has been labeled with an integration (songpal) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of songpal can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign songpal Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

songpal documentation
songpal source
_{^{(message by IssueLinks)}}

home-assistant · 2024-05-16T15:39:34Z

Hey there @exxamalte, mind taking a look at this issue as it has been labeled with an integration (gdacs) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of gdacs can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign gdacs Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

gdacs documentation
gdacs source
_{^{(message by IssueLinks)}}

home-assistant · 2024-05-16T15:39:34Z

Hey there @exxamalte, mind taking a look at this issue as it has been labeled with an integration (geonetnz_quakes) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of geonetnz_quakes can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign geonetnz_quakes Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

geonetnz_quakes documentation
geonetnz_quakes source
_{^{(message by IssueLinks)}}

home-assistant · 2024-05-16T15:39:34Z

Hey there @marciogranzotto, mind taking a look at this issue as it has been labeled with an integration (nightscout) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nightscout can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign nightscout Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

nightscout documentation
nightscout source
_{^{(message by IssueLinks)}}

home-assistant · 2024-05-16T15:39:34Z

Hey there @raman325, mind taking a look at this issue as it has been labeled with an integration (vizio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vizio can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign vizio Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

vizio documentation
vizio source
_{^{(message by IssueLinks)}}

farmio · 2024-05-16T18:44:20Z

@janiversen in knx we use it to dump the whole yaml config. Maybe that would be an option for Modbus too.
fronius integration doesn't use Modbus btw. but a local HTTP API. Not really sure what to log here though.

joostlek · 2024-05-16T18:46:25Z

Modbus isn't config entry based, so does diagnostics even work for them?

tronikos · 2024-05-16T18:51:30Z

Yes Google Assistant SDK still connects to a service but my understanding of: "When communicating with a device or service" refers to https://developers.home-assistant.io/docs/architecture/devices-and-services/ which doesn't apply here. Putting just the language code in diagnostics isn't particularly useful.

janiversen · 2024-05-16T18:55:02Z

@joostlek that is my point from earlier, the definition is "When communicating with a device or service, the integration implements the diagnostics platform which redacts sensitive information.", and not like the other demands, which have "if available", so it seems it MUST be implemented even if it does not work.

What I will be doing for modbus is to dump state of the entity...but honestly it is only to satisfy the quality demand, as it will not help in diagnosing a problem.

There is also something that I do not understand, the diagnostic platform is targeted at end-users, but it seems the dict is not being translated (I might have missed it, but at least the example tplink/diagnostic.py, does not use strings.json ??

joostlek · 2024-05-16T18:57:19Z

I think that wording comes from one of the Adr, modbus is a protocol integration like mqtt. And it doesn't connect with a specific device.

janiversen · 2024-05-16T19:23:23Z

The text says "device or service, modbus communicates with a specific device !! and it was added to this PR so surely someone thinks it should be done.

MatthewFlamm · 2024-05-16T19:28:49Z

I cannot edit the issue description, but nws is completed in #117587. Thanks for the pointers and quick merge!

epenet · 2024-05-21T07:21:11Z

I have adjusted the description above.
If an integration is unable to implement diagnostic, then a PR should be opened to add a comment against the integration in script/hassfest/manifest.py, explaining why it cannot be implemented.

core/script/hassfest/manifest.py

Lines 118 to 136 in d1bdf73

    
           NO_DIAGNOSTICS = [ 
        
               "dlna_dms", 
        
               "fronius", 
        
               "gdacs", 
        
               "geonetnz_quakes", 
        
               "google_assistant_sdk", 
        
               "hyperion", 
        
               # Modbus is excluded because it doesn't have to have a config flow 
        
               # according to ADR-0010, since it's a protocol integration. This 
        
               # means that it can't implement diagnostics. 
        
               "modbus", 
        
               "nightscout", 
        
               "pvpc_hourly_pricing", 
        
               "risco", 
        
               "smarttub", 
        
               "songpal", 
        
               "vizio", 
        
               "yeelight", 
        
           ]

tronikos · 2024-05-30T19:32:33Z

#118513 takes care of Google Assistant SDK

egaryw2011 · 2024-10-07T00:54:48Z

Modbus isn't config entry based, so does diagnostics even work for them?

Hi, I am not sure who to direct my question too, I use modbus to monitor my solar system and I am in the process of cleaning up all my errors in the logs (growing a couple of gig per day).
In the error logs is the Modbus issue, how do I fix it, the following appears all the time;

Logger: homeassistant.components.modbus.validators
Source: components/modbus/validators.py:302
integration: Modbus (documentation, issues)
First occurred: October 6, 2024 at 8:06:41 AM (1 occurrences)
Last logged: October 6, 2024 at 8:06:41 AM

retries: is deprecated and will be removed in version 2024.7

Thanks in advance

cgarwood · 2024-12-18T14:33:47Z

Gonna close this now that the new quality scale system has rolled out.

home-assistant bot assigned janiversen and rytilahti May 16, 2024

MatthewFlamm mentioned this issue May 16, 2024

Add diagnostics for nws #117587

Merged

20 tasks

janiversen mentioned this issue May 16, 2024

Add diagnostics to modbus (Satisfy quality demand) #117591

Closed

20 tasks

This was referenced May 20, 2024

Downgrade point quality scale to silver #117783

Merged

Downgrade tellduslive quality scale to silver #117784

Merged

farmio mentioned this issue May 21, 2024

Add diagnostics support for Fronius #117845

Merged

20 tasks

epenet mentioned this issue May 21, 2024

Exclude modbus from diagnostics hassfest check #117855

Merged

20 tasks

janiversen removed their assignment May 30, 2024

tronikos mentioned this issue May 30, 2024

Add Google Assistant SDK diagnostics #118513

Merged

20 tasks

rytilahti mentioned this issue Jun 20, 2024

Fix songpal crash for soundbars without sound modes #119999

Merged

20 tasks

tronikos removed the integration: google_assistant_sdk label Jul 4, 2024

This was referenced Sep 5, 2024

Add diagnostics to GDACS integration #125296

Merged

Add diagnostics to GeoNet NZ Quakes integration #125320

Merged

epenet removed integration: tellduslive integration: point integration: fronius integration: nws integration: geonetnz_quakes integration: gdacs labels Sep 5, 2024

cgarwood closed this as completed Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gold and platinum integrations should implement diagnostic #117576

Gold and platinum integrations should implement diagnostic #117576

epenet commented May 16, 2024 •

edited

Loading

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

farmio commented May 16, 2024

joostlek commented May 16, 2024

tronikos commented May 16, 2024

janiversen commented May 16, 2024

joostlek commented May 16, 2024

janiversen commented May 16, 2024

MatthewFlamm commented May 16, 2024

epenet commented May 21, 2024 •

edited

Loading

tronikos commented May 30, 2024

egaryw2011 commented Oct 7, 2024

cgarwood commented Dec 18, 2024

Gold and platinum integrations should implement diagnostic #117576

Gold and platinum integrations should implement diagnostic #117576

Comments

epenet commented May 16, 2024 • edited Loading

The problem

What version of Home Assistant Core has the issue?

What was the last working version of Home Assistant Core?

What type of installation are you running?

Integration causing the issue

Link to integration documentation on our website

Diagnostics information

Example YAML snippet

Anything in the logs that might be useful for us?

Additional information

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

farmio commented May 16, 2024

joostlek commented May 16, 2024

tronikos commented May 16, 2024

janiversen commented May 16, 2024

joostlek commented May 16, 2024

janiversen commented May 16, 2024

MatthewFlamm commented May 16, 2024

epenet commented May 21, 2024 • edited Loading

tronikos commented May 30, 2024

egaryw2011 commented Oct 7, 2024

cgarwood commented Dec 18, 2024

epenet commented May 16, 2024 •

edited

Loading

epenet commented May 21, 2024 •

edited

Loading