Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add velux config flow #106660

Closed
wants to merge 33 commits into from
Closed

Conversation

pawlizio
Copy link
Contributor

Breaking change

Proposed change

Add config flow to velux integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed code-quality config-flow This integration migrates to the UI by adding a config flow deprecation Indicates a breaking change to happen in the future has-tests integration: velux new-feature Quality Scale: No score labels Dec 29, 2023
@home-assistant
Copy link

Hey there @Julius2342, mind taking a look at this pull request as it has been labeled with an integration (velux) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of velux can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign velux Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@pawlizio pawlizio force-pushed the velux_refactor branch 2 times, most recently from 5ead04d to f7f6e56 Compare December 29, 2023 20:51
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks really good!

homeassistant/components/velux/__init__.py Show resolved Hide resolved
homeassistant/components/velux/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/velux/__init__.py Show resolved Hide resolved
homeassistant/components/velux/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/velux/light.py Outdated Show resolved Hide resolved
@pawlizio pawlizio force-pushed the velux_refactor branch 2 times, most recently from 6108cb9 to 152c9e2 Compare December 30, 2023 22:55
@pawlizio pawlizio marked this pull request as ready for review January 4, 2024 21:43
@pawlizio pawlizio requested a review from Kane610 January 4, 2024 21:45
@pawlizio pawlizio force-pushed the velux_refactor branch 2 times, most recently from aa110fe to e2a68ee Compare January 4, 2024 22:02
@pawlizio pawlizio marked this pull request as draft January 4, 2024 23:06
@pawlizio pawlizio marked this pull request as ready for review January 5, 2024 19:40
@joostlek joostlek closed this Feb 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality config-flow This integration migrates to the UI by adding a config flow deprecation Indicates a breaking change to happen in the future has-tests integration: velux new-feature Quality Scale: No score
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants