-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add velux config flow #106660
Closed
Closed
Add velux config flow #106660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
config-flow
This integration migrates to the UI by adding a config flow
deprecation
Indicates a breaking change to happen in the future
has-tests
integration: velux
new-feature
Quality Scale: No score
labels
Dec 29, 2023
Hey there @Julius2342, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
pawlizio
force-pushed
the
velux_refactor
branch
2 times, most recently
from
December 29, 2023 20:51
5ead04d
to
f7f6e56
Compare
Kane610
reviewed
Dec 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks really good!
pawlizio
force-pushed
the
velux_refactor
branch
2 times, most recently
from
December 30, 2023 22:55
6108cb9
to
152c9e2
Compare
pawlizio
force-pushed
the
velux_refactor
branch
2 times, most recently
from
January 4, 2024 22:02
aa110fe
to
e2a68ee
Compare
pawlizio
force-pushed
the
velux_refactor
branch
from
January 5, 2024 18:37
3707afa
to
0f0765d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
code-quality
config-flow
This integration migrates to the UI by adding a config flow
deprecation
Indicates a breaking change to happen in the future
has-tests
integration: velux
new-feature
Quality Scale: No score
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add config flow to velux integration
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: