-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zeroconf discovery support #369
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 80.00% 79.31% -0.69%
==========================================
Files 77 78 +1
Lines 3560 3612 +52
==========================================
+ Hits 2848 2865 +17
- Misses 712 747 +35 ☔ View full report in Codecov by Sentry. |
This reverts commit 2ddeb0c.
@@ -13,7 +13,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
python-version: ["3.10", "3.11", "3.12"] | |||
python-version: ["3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^
Shouldnt we integrate this discovery in the pyvlx module itself? something like: |
I'm not sure, don't we need a separate pyvlx instances for every KLF200 which we find on the network or are we able to manage them inside one pyvlx instance? My idea for this PR was just to use it on HA side when someone start a manual configuration flow for VELUX in the UI, so that we can use zeroconf to check the network and create a list of identified KLF200 devices on the network. Those flows are used before an instance of pyvlx is created. |
Add zeroconf discovery support for Velux KLF200 devices on the network.