-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix firmware update failure #103277
Fix firmware update failure #103277
Conversation
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Tested on my dev system and is working 👍 |
|
To test it we have |
I actually do use that mock in my tests and have one where the latest_firmware_file is None but now that I think about it more I just need to adjust the state data to show an upgrade while having the latest firmware file as none |
Proposed change
There was a bug in our code that assumed a value was not None when it was. I'm pretty sure I fixed it, but I am also not sure why it's happening or how to test it.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: