Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firmware update failure #103277

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fix firmware update failure #103277

merged 2 commits into from
Nov 3, 2023

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Nov 2, 2023

Proposed change

There was a bug in our code that assumed a value was not None when it was. I'm pretty sure I fixed it, but I am also not sure why it's happening or how to test it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@raman325 raman325 added this to the 2023.11.1 milestone Nov 2, 2023
@raman325 raman325 requested a review from a team as a code owner November 2, 2023 23:37
@home-assistant
Copy link

home-assistant bot commented Nov 2, 2023

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@cgarwood
Copy link
Member

cgarwood commented Nov 3, 2023

Tested on my dev system and is working 👍

@frenck frenck merged commit ac1dc4e into dev Nov 3, 2023
23 checks passed
@frenck frenck deleted the zwave branch November 3, 2023 11:08
@MartinHjelmare
Copy link
Member

I'm pretty sure I fixed it, but I am also not sure why it's happening or how to test it.

latest_version_firmware is optional both on the entity and on the extra restore data. We need to handle that but we didn't when restoring state until this PR.

@MartinHjelmare
Copy link
Member

To test it we have mock_restore_cache_with_extra_data which I think we can use.

frenck pushed a commit that referenced this pull request Nov 3, 2023
@frenck frenck mentioned this pull request Nov 3, 2023
@raman325
Copy link
Contributor Author

raman325 commented Nov 3, 2023

I actually do use that mock in my tests and have one where the latest_firmware_file is None but now that I think about it more I just need to adjust the state data to show an upgrade while having the latest firmware file as none

@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion error of Z-Wave firmware update
4 participants