Assertion error of Z-Wave firmware update #102027

EnochPrime · 2023-10-15T01:09:55Z

The problem

When clicking the install button on the z-wave firmware entity I receive an assertion error (see below). I am specifically attempting to update Inovelli VZW31-SN from firmware 1.0.0 to 1.2.

Z-Wave JS versions
zwave-js-ui: 9.1.2.a13a720
zwave-js: 12.0.4

What version of Home Assistant Core has the issue?

core-2023.10.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

zwave_js

Link to integration documentation on our website

https://www.home-assistant.io/integrations/zwave_js/

Diagnostics information

config_entry-zwave_js-45a7b9a2c861bb370dbe004ad2bc1017.json.txt

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:226
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 20:26:50 (1 occurrences)
Last logged: 20:26:50

[139697179835584]
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 226, in handle_call_service
    await hass.services.async_call(
  File "/usr/src/homeassistant/homeassistant/core.py", line 2012, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2049, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 235, in handle_service
    return await service.entity_service_call(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 876, in entity_service_call
    response_data = await _handle_entity_call(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 948, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/update/__init__.py", line 157, in async_install
    await entity.async_install_with_progress(version, backup)
  File "/usr/src/homeassistant/homeassistant/components/update/__init__.py", line 432, in async_install_with_progress
    await self.async_install(version, backup)
  File "/usr/src/homeassistant/homeassistant/components/zwave_js/update.py", line 266, in async_install
    assert firmware
AssertionError



### Additional information

_No response_

The text was updated successfully, but these errors were encountered:

home-assistant · 2023-10-15T01:09:59Z

Hey there @home-assistant/z-wave, mind taking a look at this issue as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign zwave_js Removes the current integration label and assignees on the issue, add the integration domain after the command.

_{^{(message by CodeOwnersMention)}}

zwave_js documentation
zwave_js source
_{^{(message by IssueLinks)}}

raman325 · 2023-10-15T15:17:31Z

hmm I'm not sure how that's possible. Out of curiosity, do you know if you did an HA restart in the time between when the update was available and when you clicked install? Wondering if the restore logic is faulty

EnochPrime · 2023-10-15T16:36:34Z

do you know if you did an HA restart in the time between when the update was available and when you clicked install?

Yes, definitely. The update has been available for a while and I have restarted several times. Most recently I was using core-2023.10.1 and zwave-js-ui 9.0.3. I updated zwave-js-ui to 9.1.2 and attempted the update which failed with this error. I then updated to core-2023.10.3 and attempted again and received the same error.

raman325 · 2023-10-15T23:38:54Z

any chance you have access to the source for HA? I don't want to push an update just to add a logging statement for this issue, but I am curious what's happening on startup

EnochPrime · 2023-10-16T00:10:53Z

any chance you have access to the source for HA? I don't want to push an update just to add a logging statement for this issue, but I am curious what's happening on startup

I did recently set up the dev environment and I have some experience with python. Just let me know where you need the debugging info.

Lovski · 2023-10-19T08:19:11Z

I've got this exact same issue when trying to update firmware for any Z-wave device. Running the latest HA via Docker and Z-wave JS UI via Docker in a separate container.

EnochPrime · 2023-10-21T02:23:43Z

I checked again today and there is a description and the firmware is installing.

EnochPrime · 2023-10-22T19:32:43Z

Found some steps that seem to reproduce the issue. This assumes the description missing equates to the assertion error.

Check updates and see description
Navigate to Z-wave integration page and reload integration
Check updates and see description is gone
Restart Home Assistant
Check updates and see descriptions have returned

kpine · 2023-10-31T19:13:42Z

@raman325 Could it be this code?

core/homeassistant/components/zwave_js/update.py

Lines 344 to 348 in 6433bf4

    
           self._latest_version_firmware = ( 
        
               ZWaveNodeFirmwareUpdateExtraStoredData.from_dict( 
        
                   extra_data.as_dict() 
        
               ).latest_version_firmware 
        
           )

All of my update entities have null values for latest_version_firmware. Example:

    {
      "state": {
        "entity_id": "update.left_garage_door_opener_firmware",
        "state": "off",
        "attributes": {
          "auto_update": false,
          "installed_version": "1.30.2",
          "in_progress": false,
          "latest_version": "1.30.2",
          "release_summary": null,
          "release_url": null,
          "skipped_version": null,
          "title": null,
          "device_class": "firmware",
          "entity_picture": "https://brands.home-assistant.io/_/zwave_js/icon.png",
          "friendly_name": "Left Garage Door Opener Firmware",
          "supported_features": 21
        },
        "last_changed": "2023-10-31T14:29:37.889782+00:00",
        "last_updated": "2023-10-31T14:29:37.889782+00:00",
        "context": {
          "id": "01HE327NZ16SQJTPJJQ0ST9V8G",
          "parent_id": null,
          "user_id": null
        }
      },
      "extra_data": {
        "latest_version_firmware": null
      },
      "last_seen": "2023-10-31T18:59:37.923847+00:00"
    }

cgarwood · 2023-10-31T20:41:54Z

My prod system has null for extra_data.latest_version_firmware and gets the same error. I tested on my dev system and extra_data.latest_version_firmware was populated. When modifying core.restore_states on one of the entities and setting extra_data.latest_version_firmware to null and restarting HA, it breaks the same way as my prod system.

KorvinSzanto · 2023-11-02T15:05:08Z

I have this same issue with inovelli switches

raman325 · 2023-11-03T13:29:52Z

2023.11.1 should have the fix for this issue. Please let us know here if not, but no need to confirm it works, happy for this one to be out of sight out of mind if it does work 🙂

home-assistant bot added the integration: zwave_js label Oct 15, 2023

raman325 mentioned this issue Nov 2, 2023

Fix firmware update failure #103277

Merged

20 tasks

frenck closed this as completed in #103277 Nov 3, 2023

github-actions bot locked and limited conversation to collaborators Dec 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assertion error of Z-Wave firmware update #102027

Assertion error of Z-Wave firmware update #102027

EnochPrime commented Oct 15, 2023 •

edited

Loading

home-assistant bot commented Oct 15, 2023

raman325 commented Oct 15, 2023

EnochPrime commented Oct 15, 2023

raman325 commented Oct 15, 2023

EnochPrime commented Oct 16, 2023

Lovski commented Oct 19, 2023

EnochPrime commented Oct 21, 2023

EnochPrime commented Oct 22, 2023

kpine commented Oct 31, 2023

cgarwood commented Oct 31, 2023

KorvinSzanto commented Nov 2, 2023

raman325 commented Nov 3, 2023

Assertion error of Z-Wave firmware update #102027

Assertion error of Z-Wave firmware update #102027

Comments

EnochPrime commented Oct 15, 2023 • edited Loading

The problem

What version of Home Assistant Core has the issue?

What was the last working version of Home Assistant Core?

What type of installation are you running?

Integration causing the issue

Link to integration documentation on our website

Diagnostics information

Example YAML snippet

Anything in the logs that might be useful for us?

home-assistant bot commented Oct 15, 2023

raman325 commented Oct 15, 2023

EnochPrime commented Oct 15, 2023

raman325 commented Oct 15, 2023

EnochPrime commented Oct 16, 2023

Lovski commented Oct 19, 2023

EnochPrime commented Oct 21, 2023

EnochPrime commented Oct 22, 2023

kpine commented Oct 31, 2023

cgarwood commented Oct 31, 2023

KorvinSzanto commented Nov 2, 2023

raman325 commented Nov 3, 2023

EnochPrime commented Oct 15, 2023 •

edited

Loading