-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BIOMAGE-1903] add two checkboxes for compliance #772
Conversation
…l instead (for testing purposes)
…d move redux data to redux
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
Page | Size (compressed) |
---|---|
global |
521.87 KB (🟡 +5.04 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Sixteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/401 |
2.31 KB (🟢 -1 B) |
524.18 KB |
/404 |
2.31 KB (🟡 +11 B) |
524.18 KB |
/_error |
2.7 KB (🟡 +2 B) |
524.56 KB |
/data-management |
246.41 KB (🟢 -1.99 KB) |
768.28 KB |
/experiments/[experimentId]/data-exploration |
531.46 KB (🟢 -2.13 KB) |
1.03 MB |
/experiments/[experimentId]/data-processing |
496.82 KB (🟢 -2.13 KB) |
1018.68 KB |
/experiments/[experimentId]/plots-and-tables |
14.87 KB (🟡 +2 B) |
536.74 KB |
/experiments/[experimentId]/plots-and-tables/dot-plot |
474.12 KB (🟢 -2.14 KB) |
995.98 KB |
/experiments/[experimentId]/plots-and-tables/embedding-categorical |
470.76 KB (🟢 -2.14 KB) |
992.62 KB |
/experiments/[experimentId]/plots-and-tables/embedding-continuous |
471.27 KB (🟢 -2.14 KB) |
993.13 KB |
/experiments/[experimentId]/plots-and-tables/frequency |
473.04 KB (🟢 -2.13 KB) |
994.91 KB |
/experiments/[experimentId]/plots-and-tables/heatmap |
544.25 KB (🟢 -2.14 KB) |
1.04 MB |
/experiments/[experimentId]/plots-and-tables/marker-heatmap |
569.15 KB (🟢 -2.13 KB) |
1.07 MB |
/experiments/[experimentId]/plots-and-tables/violin |
471.56 KB (🟢 -2.13 KB) |
993.42 KB |
/experiments/[experimentId]/plots-and-tables/volcano |
475.03 KB (🟢 -2.13 KB) |
996.89 KB |
/settings/profile |
28.18 KB (🟡 +2.06 KB) |
550.04 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
9e4f634
to
3b257e3
Compare
is this not going to be staged? or it's not required? |
It is staged, I didn't add it in the correct place in the ui side because I don't want to fight the integraiton tests checks twice, once for the api and once for the ui |
Description
Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-1903
https://ui-martinfosco-ui772-api394i.scp-staging.biomage.net/
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
hms-dbmi-cellenics/api#394
hms-dbmi-cellenics/iac#490
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional