Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1903 add two checkboxes for compliance #490

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Jul 13, 2022

Background

Link to issue

https://biomage.atlassian.net/browse/BIOMAGE-1903

Link to staging deployment URL

Links to any Pull Requests related to this

hms-dbmi-cellenics/api#394
hms-dbmi-cellenics/ui#772

Anything else the reviewers should know about the changes here

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/hms-dbmi-cellenics/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/hms-dbmi-cellenics/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@cosa65 cosa65 merged commit 32f4090 into master Jul 18, 2022
@cosa65 cosa65 deleted the 1903-add-two-checkboxes-for-compliance branch July 18, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants