Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample create delete api v2 #676

Merged
merged 16 commits into from
Apr 12, 2022
Merged

Sample create delete api v2 #676

merged 16 commits into from
Apr 12, 2022

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Apr 7, 2022

Description

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-1805

https://ui-martinfosco-ui676-api330.scp-staging.biomage.net/

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

hms-dbmi-cellenics/api#330

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@cosa65 cosa65 marked this pull request as draft April 7, 2022 17:19
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 522 KB (🟡 +282 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/data-management 295.83 KB (🟡 +340 B) 817.83 KB
/experiments/[experimentId]/data-processing 503.25 KB (🟡 +295 B) 1 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #676 (9e32f8e) into master (cc277f6) will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage   81.49%   81.50%   +0.01%     
==========================================
  Files         463      465       +2     
  Lines        7901     7927      +26     
  Branches     1519     1525       +6     
==========================================
+ Hits         6439     6461      +22     
- Misses       1407     1411       +4     
  Partials       55       55              
Impacted Files Coverage Δ
src/redux/actions/experiments/createExperiment.js 89.47% <ø> (ø)
src/redux/actions/projects/deleteProject.js 100.00% <ø> (ø)
src/redux/reducers/projects/samplesCreate.js 100.00% <ø> (ø)
src/redux/reducers/experiments/samplesDelete.js 33.33% <33.33%> (ø)
src/redux/reducers/projects/samplesDelete.js 33.33% <33.33%> (ø)
src/redux/actions/samples/createSample.js 88.88% <81.81%> (-5.56%) ⬇️
src/redux/actionTypes/samples.js 100.00% <100.00%> (ø)
src/redux/actions/projects/loadProjects.js 100.00% <100.00%> (ø)
src/redux/actions/samples/deleteSamples.js 100.00% <100.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc277f6...9e32f8e. Read the comment docs.

@cosa65 cosa65 changed the title [DRAFT] Sample create delete api v2 Sample create delete api v2 Apr 8, 2022
@cosa65 cosa65 marked this pull request as ready for review April 8, 2022 14:42
Comment on lines 63 to 65
// This section commented out because we going to use it
// when samples loading is implemented in api v2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be left because we are going to use it one we implement samples loading

@cosa65 cosa65 enabled auto-merge April 12, 2022 14:37
@cosa65 cosa65 merged commit 8368ddd into master Apr 12, 2022
@cosa65 cosa65 deleted the sample-create-delete-v2 branch April 12, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants