Sample create delete api v2 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them to use on creation (this way we can make them all use the same transaction)
…d BasicModel methods and alternative usage of knex transaction
cosa65
changed the title
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 82.44% 82.65% +0.21%
==========================================
Files 102 107 +5
Lines 2831 2895 +64
Branches 300 306 +6
==========================================
+ Hits 2334 2393 +59
- Misses 451 457 +6
+ Partials 46 45 -1
Continue to review full report at Codecov.
|
cosa65
changed the title
9 tasks
ivababukova
reviewed
Apr 11, 2022
ivababukova
reviewed
Apr 11, 2022
ivababukova
reviewed
Apr 11, 2022
ivababukova
reviewed
Apr 11, 2022
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('create works correctly', async () => { |
There was a problem hiding this comment.
I don't see any tests for failure modes. Is there something we can test for?
There was a problem hiding this comment.
I don't really think there are any unit tests to add there since all BasicModel does is do part of a query
ivababukova
reviewed
Apr 11, 2022
ivababukova
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.