Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incresaed cleanup operator time #184

Merged
merged 18 commits into from
Oct 31, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion chart-infra/templates/kube-cleanup-operator-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ spec:
# delete orphaned pods after 1s, so successfully run
# workers wont linger around
- --legacy-mode=false
- --delete-orphaned-pods-after=1s
# wait up to 6 minutes to avoid removing pods which are in containerCreating but are already assigned
- --delete-orphaned-pods-after=3600s
image: quay.io/lwolf/kube-cleanup-operator
imagePullPolicy: Always
name: cleanup-operator
Expand Down
1 change: 1 addition & 0 deletions pipeline-runner/R/gem2s-7-upload_to_aws.R
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ upload_to_aws <- function(input, pipeline_config, prev_out) {
fpath <- file.path(tempdir(), 'experiment.rds')
saveRDS(scdata, fpath, compress = FALSE)

# can only upload up to 50Gb because part numbers can be any number from 1 to 10,000, inclusive.
put_object_in_s3_multipart(pipeline_config,
bucket = pipeline_config$source_bucket,
object = fpath,
Expand Down
2 changes: 1 addition & 1 deletion pipeline-runner/init.R
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ init <- function() {
cause = error_txt
)

send_pipeline_fail_update(pipeline_config, input_parse$experimentId, input_parse$processName, "Error message placeholder")
send_pipeline_fail_update(pipeline_config, input_parse$experimentId, input_parse$processName, error_txt)

message("Sent task failure to state machine task: ", taskToken)
message("recovered from error:", e$message)
Expand Down