incresaed cleanup operator time #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
- Coverage 59.45% 59.40% -0.05%
==========================================
Files 19 19
Lines 1238 1239 +1
==========================================
Hits 736 736
- Misses 502 503 +1
Continue to review full report at Codecov.
|
ivababukova
approved these changes
Oct 29, 2021
kafkasl
force-pushed
the
cleanup-operator
branch
from
d610fcf to
c3581c4
Compare
marcellp
approved these changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased cleanup operator waiting time. The api will start assigning experiments to pods which are in
ContainerCreatingstate. When containers are assigned they effectively become orphaned. They are not removed if they are running, but duringContainerCreatingphase they will be. I am increasing the timeout to 6 minutes so the pods won't be removed while fargate is creating them (which should happen under 4 minutes)Related PR: hms-dbmi-cellenics/api#252