Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIOMAGE-2014] - Fix staging SHA #390

Merged
merged 6 commits into from
Jul 7, 2022
Merged

[BIOMAGE-2014] - Fix staging SHA #390

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a517c0
stage with commit sha
aerlaut Jul 6, 2022
d4a3e02
fix ref-tag
aerlaut Jul 6, 2022
0a78618
refactor ci
aerlaut Jul 7, 2022
26fccb9
exporting ref id
aerlaut Jul 7, 2022
500946a
use correct sha
aerlaut Jul 7, 2022
d81f054
address comments
aerlaut Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ jobs:
name: Build Docker container
runs-on: ubuntu-20.04
needs: test
outputs:
ref-tag: ${{ steps.ref.outputs.tag }}
steps:
- id: checkout
name: Check out source code
Expand Down Expand Up @@ -246,7 +248,7 @@ jobs:
RDS_SANDBOX_ID="default"
CHART_REF="master"
KUBERNETES_ENV="staging"
IMAGE_TAG="$REF_DASHED-$GITHUB_SHA"
IMAGE_TAG="$REF_TAG"
IMAGE_GLOB="glob:$REF_DASHED-*"
REPLICA_COUNT="2"
fi
Expand All @@ -256,7 +258,7 @@ jobs:
RDS_SANDBOX_ID="STAGING_RDS_SANDBOX_ID"
CHART_REF="STAGING_CHART_REF"
KUBERNETES_ENV="staging"
IMAGE_TAG="$REF_DASHED-$GITHUB_SHA"
IMAGE_TAG="$REF_TAG"
IMAGE_GLOB="glob:$REF_DASHED-*"
REPLICA_COUNT="1"
fi
Expand Down Expand Up @@ -285,6 +287,7 @@ jobs:
cat $DEPLOYMENT_NAME.yaml
env:
IMAGE_NAME: ${{ format('{0}/{1}:{2}', steps.login-ecr.outputs.registry, needs.build-docker.outputs.repo-name, needs.build-docker.outputs.tag) }}
REF_TAG: ${{ needs.build-docker.outputs.ref-tag }}


- id: disable-admin-enforcement
Expand Down