Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIOMAGE-2014] - Fix staging SHA #390

Merged
merged 6 commits into from
Jul 7, 2022
Merged

[BIOMAGE-2014] - Fix staging SHA #390

merged 6 commits into from
Jul 7, 2022

Conversation

aerlaut
Copy link
Contributor

@aerlaut aerlaut commented Jul 6, 2022

Description

PR #388 introduces a fix to use the appropriate commit sha to tag images. It is tagging the docker images properly, but wasn't properly picked up by the staging-candidates for the PRs. This PR fixes taht.

Details

URL to issue

https://biomage.atlassian.net/browse/BIOMAGE-2014

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

N/A

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@aerlaut aerlaut changed the title stage with commit sha [BIOMAGE-2014] - Fix staging SHA Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #390 (d81f054) into master (220679a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files         167      167           
  Lines        4575     4575           
  Branches      487      487           
=======================================
  Hits         4060     4060           
  Misses        482      482           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 220679a...d81f054. Read the comment docs.

@aerlaut aerlaut merged commit 6f6f6c5 into master Jul 7, 2022
@aerlaut aerlaut deleted the fix-staging-sha branch July 7, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants