Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as of AzureRM Provider 3.105.0 the property `public_network_access_en… #61

Merged
merged 2 commits into from
May 28, 2024
Merged

as of AzureRM Provider 3.105.0 the property `public_network_access_en… #61

merged 2 commits into from
May 28, 2024

Conversation

charlesluokb
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/DTSPO-17844

Change description

as of AzureRM Provider 3.105.0 the property public_network_access_enabled needs to be set explicitly
hashicorp/terraform-provider-azurerm#26098

Checklist

  • commit messages are meaningful and follow good commit message guidelines

@charlesluokb charlesluokb requested a review from a team as a code owner May 28, 2024 11:40
thomast1906
thomast1906 requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@thomast1906 thomast1906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing input reference, check other variables

@charlesluokb
Copy link
Contributor Author

@thomast1906 are you referring to the property needs to be defined in the file inputs-required.tf?

@endakelly endakelly mentioned this pull request May 28, 2024
Closed
4 tasks
@endakelly endakelly mentioned this pull request May 28, 2024
Closed
4 tasks
@danielwilsonkainos
Copy link
Contributor

Looks fine to me now its correctly formatted?

thomast1906
thomast1906 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@thomast1906 thomast1906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure we have tested against likes of Plum

@charlesluokb
Copy link
Contributor Author

test on sandbox-build Jenkins
https://sandbox-build.hmcts.net/job/HMCTS_a_to_c_Sandbox/job/cnp-plum-recipes-service/job/DTSPO-17844-testFix/1/

test on build Jenkins
https://build.hmcts.net/blue/organizations/jenkins/HMCTS_a_to_c%2Fcnp-plum-recipes-service/activity?branch=PR-1004

danielwilsonkainos
danielwilsonkainos approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@danielwilsonkainos danielwilsonkainos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test are fine, looks good to merge

@charlesluokb charlesluokb merged commit f72e6e4 into master May 28, 2024
5 checks passed
@charlesluokb charlesluokb deleted the DTSPO-17844-publicNetworkAccessConflicts branch May 28, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielwilsonkainos danielwilsonkainos danielwilsonkainos approved these changes

@thomast1906 thomast1906 thomast1906 approved these changes

@ciaranca ciaranca Awaiting requested review from ciaranca ciaranca is a code owner automatically assigned from hmcts/platform-operations

@louisehuyton louisehuyton Awaiting requested review from louisehuyton louisehuyton is a code owner automatically assigned from hmcts/platform-operations

@JordanHoey96 JordanHoey96 Awaiting requested review from JordanHoey96 JordanHoey96 is a code owner automatically assigned from hmcts/platform-operations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesluokb @danielwilsonkainos @thomast1906