Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMP-3816: ARM RPO - Update the RPO CSV & Replay Time Range #2277

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Ben-Edwards-cgi
Copy link
Contributor

Links

Jira

Change description

Summary of Git Diff

This Git diff introduces several modifications primarily to the AdminPatchAutomatedTaskTest and related classes. The changes include new methods to handle ARM automated tasks, updates to existing entities and services, and the introduction of error handling for incorrect task types. Additionally, new tests have been added to ensure the functionality of the updated features.

Highlights

  • New Test Cases:

    • Added tests in AdminPatchAutomatedTaskTest to verify:
      • Successful patching of ARM automated tasks by super admins.
      • Handling of invalid automated task types when attempting to patch.
  • Entity Updates:

    • Modified ArmAutomatedTaskEntity to use @OneToOne relationship with AutomatedTaskEntity, changing the fetch type to FetchType.LAZY.
    • Updated AutomatedTaskEntity to include a @OneToOne relationship back to ArmAutomatedTaskEntity with @NotAudited.
  • Service Implementation Changes:

    • In AdminAutomatedTasksServiceImpl, added transactional support for updates to ARM automated tasks.
    • Enhanced the updateAutomatedTask method to handle ARM-specific fields and throw an exception if a non-ARM task attempts to update ARM fields.
  • Error Handling:

    • Introduced a new error type INCORRECT_AUTOMATED_TASK_TYPE in AutomatedTaskApiError for improved error reporting.
  • OpenAPI Specification:

    • Updated tasks.yaml to include new fields for ARM automated tasks, ensuring API documentation reflects recent changes.
  • Unit Test Enhancements:

    • In AdminAutomatedTasksServiceImplTest, added tests to verify:
      • Proper handling of ARM fields during updates.
      • Validation when updating a non-ARM task with ARM-specific fields.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@Ben-Edwards-cgi Ben-Edwards-cgi requested review from a team as code owners November 15, 2024 12:41
@Ben-Edwards-cgi Ben-Edwards-cgi requested review from davet1985, jackmaloney, hemantasharma1129, madjava, ozzyib and Tyler-35 and removed request for a team November 15, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant