Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure CLI code #2946

Closed
wants to merge 6 commits into from
Closed

Restructure CLI code #2946

wants to merge 6 commits into from

Conversation

seriva
Copy link
Collaborator

@seriva seriva commented Feb 3, 2022

@przemyslavic Attached are the original init outputs for every provider, full and non-full to compare against:

any-full.txt
any-minimal.txt
aws-full.txt
aws-minimal.txt
azure-full.txt
azure-minimal.txt

Note that the any-full.txt will be slightly different because its also merged now, rest should be all the same.

@seriva seriva marked this pull request as ready for review February 3, 2022 12:39
@przemyslavic
Copy link
Collaborator

Maybe this is a good opportunity to improve this timeout as well 😏
https://github.com/epiphany-platform/epiphany/blob/develop/cli/engine/providers/azure/APIProxy.py#L51

2:53:14 INFO cli.engine.providers.azure.APIProxy - Waiting 60 seconds...55
12:53:15 INFO cli.engine.providers.azure.APIProxy - Waiting 60 seconds...56
12:53:16 INFO cli.engine.providers.azure.APIProxy - Waiting 60 seconds...57
12:53:17 INFO cli.engine.providers.azure.APIProxy - Waiting 60 seconds...58
12:53:18 INFO cli.engine.providers.azure.APIProxy - Waiting 60 seconds...59
12:53:21 INFO cli.engine.providers.azure.APIProxy - Running: "az account set --subscription xxx"
12:53:21 INFO cli.engine.providers.azure.APIProxy - Done running "az account set --subscription xxx"

@seriva
Copy link
Collaborator Author

seriva commented Feb 3, 2022

never

Maybe this is a good opportunity to improve this timeout as well 😏 https://github.com/epiphany-platform/epiphany/blob/develop/cli/engine/providers/azure/APIProxy.py#L51

2:53:14 INFO cli.engine.providers.azure.APIProxy - Waiting 60 seconds...55
12:53:15 INFO cli.engine.providers.azure.APIProxy - Waiting 60 seconds...56
12:53:16 INFO cli.engine.providers.azure.APIProxy - Waiting 60 seconds...57
12:53:17 INFO cli.engine.providers.azure.APIProxy - Waiting 60 seconds...58
12:53:18 INFO cli.engine.providers.azure.APIProxy - Waiting 60 seconds...59
12:53:21 INFO cli.engine.providers.azure.APIProxy - Running: "az account set --subscription xxx"
12:53:21 INFO cli.engine.providers.azure.APIProxy - Done running "az account set --subscription xxx"

This one I know for sure is actually needed, as Azure just doesn't propagate the SP in time before Terraform starts to run otherwise.

@przemyslavic
Copy link
Collaborator

But why 60 and not e.g. 20 🤔 I know it works fine with 60 for sure.
OK if it's more complex and there is no easy way to check SP availability, let's leave it as is.

@seriva seriva changed the title Fixes for issues #2944 and #2945. Restructure CLI code Feb 3, 2022
@seriva seriva closed this Feb 4, 2022
@seriva seriva deleted the fix/python-qoli branch February 4, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants