Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] epicli apply sleeps 10 seconds after creating inventory #2945

Closed
8 of 18 tasks
to-bar opened this issue Feb 3, 2022 · 1 comment
Closed
8 of 18 tasks

[BUG] epicli apply sleeps 10 seconds after creating inventory #2945

to-bar opened this issue Feb 3, 2022 · 1 comment
Assignees
@seriva
Labels
python Pull requests that update Python code type/bug type/performance

Comments

@to-bar
Copy link
Contributor

to-bar commented Feb 3, 2022 •
edited by seriva
Loading

Describe the bug
We have unconditional sleep call in epicli code:
https://github.com/epiphany-platform/epiphany/blob/c687e8eca0347fda6dd7a0b092deafeccdb53fb6/cli/engine/ansible/AnsibleRunner.py#L109

How to reproduce
Steps to reproduce the behavior:

  1. execute epicli apply ...

Expected behavior
Run without wasting time for sleeping or wait for something conditionally (explicitly) as long as needed instead of static 10 seconds.

Environment

  • Any

epicli version: 1.3.0 and older

Additional context
n/a

DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
@seriva seriva self-assigned this Feb 3, 2022
This was referenced Feb 3, 2022
Closed
Merged
seriva added a commit that referenced this issue Feb 8, 2022
@seriva
Fixes for #2944 and #2945 (#2948)
e5d9b90 
* Fixes for #2944 and #2945
* Move intentory loading code to build_io.py
* Minor fixes in debug dump.
rafzei pushed a commit to rafzei/epiphany that referenced this issue Feb 8, 2022
@seriva @rafzei
Fixes for hitachienergy#2944 and hitachienergy#2945 (hitachienergy#2948)
ed5683a 
* Fixes for hitachienergy#2944 and hitachienergy#2945
* Move intentory loading code to build_io.py
* Minor fixes in debug dump.
@przemyslavic
Copy link
Collaborator

Tested together with #2944.

@seriva seriva closed this as completed Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seriva seriva

Labels
python Pull requests that update Python code type/bug type/performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seriva @przemyslavic @to-bar