Kafka - configurable javax.net.debug setting #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plirglo
previously approved these changes
Dec 8, 2020
sk4zuzu
previously approved these changes
Dec 8, 2020
| @@ -2,6 +2,12 @@ | |||
| Description=Kafka Daemon | |||
| After=zookeeper.service | |||
|
|
|||
| {% if specification.kafka_var.javax_net_debug is defined %} | |||
There was a problem hiding this comment.
kafka_var ? maybe we should refactor this sometime in the future ? 🤔
There was a problem hiding this comment.
@sk4zuzu have you seen "Gopher's day" movie? ;)
javax.net.debug option is disabled by default and configurable from kafka yaml (kafka_var.javax_net_debug)
toszo
force-pushed
the
fix/kafka-disable-debug
branch
from
216d368 to
ebd17a7
Compare
atsikham
approved these changes
Dec 8, 2020
sk4zuzu
approved these changes
Dec 8, 2020
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified kafka.service.j2 to handle configurable
javax_net_debugwhich by default will be disabled (commented).Tested on ubuntu onprem.