Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: rename 'kafka_var' setting #2803

Closed
11 of 13 tasks
atsikham opened this issue Dec 20, 2021 · 0 comments
Closed
11 of 13 tasks

Refactor: rename 'kafka_var' setting #2803

atsikham opened this issue Dec 20, 2021 · 0 comments
Assignees
@przemyslavic @cicharka
Labels
type/low-hanging-fruit Good, nice, simple task

Comments

@atsikham
Copy link
Contributor

atsikham commented Dec 20, 2021 •
edited by seriva
Loading

kafka_var ? maybe we should refactor this sometime in the future ? 🤔

Originally posted by @sk4zuzu in #1891 (comment)

As Kafka is the component lets just move all these settings straight in the root of specification.

specification.kafka_var. ... -> specification. ...

DoD checklist

  • Changelog updated
  • COMPONENTS.md updated / doesn't need to be updated
  • Schema updated / doesn't need to be updated
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Idempotency tested
  • Documentation added / updated / doesn't need to be updated
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
  • Backport tasks created / doesn't need to be backported
@cicharka cicharka self-assigned this Feb 23, 2022
cicharka added a commit to cicharka/epiphany that referenced this issue Feb 24, 2022
@cicharka
Remove kafka_var hitachienergy#2803
f853cb3
cicharka added a commit to cicharka/epiphany that referenced this issue Feb 24, 2022
@cicharka
Remove kafka_var hitachienergy#2803
c852d8c
cicharka added a commit to cicharka/epiphany that referenced this issue Feb 28, 2022
@cicharka
Remove kafka_var hitachienergy#2803
c448a4f
cicharka added a commit to cicharka/epiphany that referenced this issue Mar 4, 2022
@cicharka
Remove kafka_var hitachienergy#2803
756dcd3
@przemyslavic przemyslavic self-assigned this Mar 23, 2022
cicharka added a commit to cicharka/epiphany that referenced this issue Mar 23, 2022
@cicharka
Remove kafka_var hitachienergy#2803
e67e90a
cicharka added a commit to cicharka/epiphany that referenced this issue Mar 28, 2022
@cicharka
Remove kafka_var hitachienergy#2803
50421b7
cicharka added a commit that referenced this issue Mar 28, 2022
@cicharka
Kafka upgrade (#2871) (#2803) (#2990)
7537ead 
Kafka: 
* upgrade to 2.8.1 version
* move upgrade tasks to Kafka role
* refactor installation and upgrade tasks
* refactor: rename 'kafka_var' setting

Zookeeper:
* refactor installation and upgrade
* move upgrade tasks to Zookeeper role

Kafka-exporter:
* verify if service definition needs to be updated even if exporter itself was not updated
* remove `kafka.version` from configuration
@seriva seriva closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@przemyslavic przemyslavic

@cicharka cicharka

Labels
type/low-hanging-fruit Good, nice, simple task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@atsikham @seriva @przemyslavic @cicharka