Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport ability to change control plane certificates expiration date #1796
Backport ability to change control plane certificates expiration date #1796
Changes from 3 commits
a780e55
a181367
c9178cf
e3a7435
db90bc3
4d2f07c
2f0d2ec
a0fd877
c43487c
4ede6bd
4c0f6d8
484af85
01af5cb
d9ff791
11a49f5
0a0be9d
dd172bf
ac13805
07751c4
780f194
7833863
2245595
f530660
f38d039
954f52a
70cd85f
6c0c646
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html#with-dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@to-bar could you provide an example with using dict in place like here, not in a separate var? What is the reason to change everything to a loop? Does it increase readability or there is some plans for not supporting with_* loops?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can keep
with_*
syntax since it's not deprecated yet. More info here.For migrating from
with_dict
it seems a var is required, for example:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html#with-together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same question here and for other similar requested changes as for
with_dict
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html#with-dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html#with-nested-with-cartesian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intersect
is more intuitive to me 😉There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@to-bar in this case if you pass
['docker', 'kubelet', 'kafka']
, you will allow to restart all of them. See original comment.