-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to change control plane certificates expiration date #1595
Ability to change control plane certificates expiration date #1595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question.
…ithub.com/TolikT/epiphany into feature/long-lasting-certificates-openssl
/azp run |
...epicli/data/common/ansible/playbooks/roles/kubernetes_master/tasks/generate-certificates.yml
Outdated
Show resolved
Hide resolved
...epicli/data/common/ansible/playbooks/roles/kubernetes_master/tasks/generate-certificates.yml
Outdated
Show resolved
Hide resolved
...epicli/data/common/ansible/playbooks/roles/kubernetes_master/tasks/generate-certificates.yml
Outdated
Show resolved
Hide resolved
@atsikham I've done some testing on the PR.
The bottom one is default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes are related to #1302. Documentation is updated with config description.
NOTE: it is not possible to use openssl_* modules at the moment - #1593
NOTE: kubelet.conf is not updated because according to documentation kubeadm configures kubelet for automatic certificate renewal. To verify that, navigate to
/var/lib/kubelet/config.yaml
file and check ifrotateCertificates
istrue
(default in kubeadm), also check if there are files with dates in/var/lib/kubelet/pki
.Cases need to be tested 'at least':
renew: true
andrenew:false
with different periods, including defaultkubeadm alpha certs renew all