Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pki config from manifest for apiserver certificates #1626

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Use pki config from manifest for apiserver certificates #1626

merged 1 commit into from
Sep 10, 2020

Conversation

atsikham
Copy link
Contributor

@atsikham atsikham commented Sep 8, 2020 •
edited
Loading

These changes are related to #1556, but as I knew about this configuration parameter only during #1595 implementation, PR is created now.

@atsikham atsikham self-assigned this Sep 8, 2020
@atsikham atsikham marked this pull request as ready for review September 8, 2020 11:10
mkyc
mkyc reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@mkyc mkyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to some task?

@atsikham
Copy link
Contributor Author

atsikham commented Sep 9, 2020

@mkyc it could be #1520, but it's not there because of the reason written in description. So I decided to fix that without any task.

mkyc
mkyc approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@mkyc mkyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sk4zuzu
sk4zuzu approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@sk4zuzu sk4zuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atsikham atsikham merged commit 55b6dde into hitachienergy:develop Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkyc mkyc mkyc approved these changes

@sk4zuzu sk4zuzu sk4zuzu approved these changes

Assignees

@atsikham atsikham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atsikham @sk4zuzu @mkyc