-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apiserver certificate SANs with k8s master IPs #1556
Merged
atsikham
merged 17 commits into
hitachienergy:develop
from
atsikham:issue/kubectl-update-san
Aug 18, 2020
Merged
Update apiserver certificate SANs with k8s master IPs #1556
atsikham
merged 17 commits into
hitachienergy:develop
from
atsikham:issue/kubectl-update-san
Aug 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated without additional SANs
atsikham
changed the title
Issue/kubectl update san
Update apiserver certificate SANs with k8s master IPs
Aug 13, 2020
jonmurphy407
previously approved these changes
Aug 14, 2020
sk4zuzu
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have manually tested the following scenarios:
- multi master deployment (3 instances) ✔️
- single non-ha master deployment ✔️
- promotion from single non-ha master ✔️
- scaling up from single master to multi master (3 instances) ✔️
Code quality seems good, LGTM 👍.
seriva
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #1520
Changes were made according to design spec. Important note that kubectl will act as before with private IPs if they were not used in ansible inventory, as initially k8s apiserver certificates have only SANs related to current node, for example
Cases that were tested:
Tests were performed with 3-master k8s clusters.
To check that changes work as expected: