feat: Refactor SignatureMap for Multi-Transaction Support in _signedTransactions #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
SvetBorislavov
force-pushed
the
feat/signing-changes-chunks
branch
from
92b3bd4 to
0da5a6f
Compare
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2601 +/- ##
==========================================
+ Coverage 84.71% 84.79% +0.08%
==========================================
Files 283 284 +1
Lines 71086 71227 +141
==========================================
+ Hits 60218 60399 +181
+ Misses 10868 10828 -40 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Svetoslav Borislavov <[email protected]>
ivaylonikolov7
changed the title
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
0xivanov
reviewed
Oct 28, 2024
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
0xivanov
previously approved these changes
Oct 29, 2024
Signed-off-by: Ivaylo Nikolov <[email protected]>
|
This was referenced Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the SignatureMap to support multiple transactions per node in _signedTransactions. It replaces NodeAccountIdSignatureMap with a SignaturePairMap mapped by TransactionId, allowing each node to store signatures for multiple transactions. This update resolves the issue where only the first transaction's signatures were accessible, ensuring comprehensive signature retrieval across all transactions including chunked Transactions.
Related issue(s):
#2595
Fixes #
#2595
Checklist