refactor: extract variables to const

Signed-off-by: Ivaylo Nikolov <[email protected]>
hiero-ledger · Oct 29, 2024 · 9682128 · 9682128
1 parent 1f4f32a
commit 9682128
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/src/transaction/NodeAccountIdSignatureMap.js b/src/transaction/NodeAccountIdSignatureMap.js
@@ -68,13 +68,14 @@ export default class NodeAccountIdSignatureMap extends ObjectMap {
      * @param {Uint8Array} signature
      */
     addSignature(txId, publicKey, signature) {
-        if (!this.get(txId)) {
+        const sigPairMap = this.get(txId);
+        if (sigPairMap) {
+            sigPairMap.addSignature(publicKey, signature);
+        } else {
             this._set(
                 txId,
                 new SignaturePairMap().addSignature(publicKey, signature),
             );
-        } else {
-            this.get(txId)?.addSignature(publicKey, signature);
         }
     }
 }
diff --git a/src/transaction/SignatureMap.js b/src/transaction/SignatureMap.js
@@ -85,20 +85,18 @@ export default class SignatureMap extends ObjectMap {
      * @returns {SignatureMap}
      */
     addSignature(nodeId, txId, publicKey, signature) {
-        if (!this.get(nodeId)) {
-            this._set(nodeId, new NodeAccountIdSignatureMap());
-        }
+        let nodeAccountIdSigdMap = this.get(nodeId);
 
-        const nodeAccountIdSigdMap = this.get(nodeId);
         if (!nodeAccountIdSigdMap) {
-            throw new Error("Node Account ID Signature Map not found");
+            nodeAccountIdSigdMap = new NodeAccountIdSignatureMap();
+            this._set(nodeId, nodeAccountIdSigdMap);
         }
 
         nodeAccountIdSigdMap.addSignature(txId, publicKey, signature);
         this._set(nodeId, nodeAccountIdSigdMap);
+
         return this;
     }
-
     /**
      * @returns {SignaturePairMap[]}
      */