Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hibernate.jdbc.use_get_generated_keys #1552

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Apr 3, 2023

This property might make sense with JDBC. But the Vert.x client is less flexible about the type of queries it needs to read the id.

@gavinking
Copy link
Member

Also, deleting 140 lines of code is nice :)

@DavideD
Copy link
Member Author

DavideD commented Apr 3, 2023

I will change it to a draft because I'm still experimenting with some changes that should remove more unecessary code

@DavideD DavideD marked this pull request as draft April 3, 2023 10:49
@DavideD DavideD force-pushed the identity-generator branch 3 times, most recently from a42db94 to b4f4c58 Compare April 3, 2023 11:45
DavideD added 3 commits April 3, 2023 14:55
This property might make sense with JDBC. But the Vert.x client
is less flexible about the type of queries it needs to read the id.
@DavideD DavideD force-pushed the identity-generator branch from b4f4c58 to 94ed758 Compare April 3, 2023 13:00
@DavideD DavideD marked this pull request as ready for review April 3, 2023 13:01
@DavideD
Copy link
Member Author

DavideD commented Apr 3, 2023

Now we don't need the dialect wrapper anymore

@DavideD DavideD merged commit 0815b7f into hibernate:main Apr 3, 2023
@DavideD DavideD deleted the identity-generator branch April 3, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants