Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify identity generation #1553

Closed
DavideD opened this issue Apr 3, 2023 · 2 comments
Closed

Simplify identity generation #1553

DavideD opened this issue Apr 3, 2023 · 2 comments
Assignees
@DavideD
Milestone
2.0.0.Beta2

Comments

@DavideD
Copy link
Member

DavideD commented Apr 3, 2023

JDBC can generate an identity using different strategies. One can tell Hibernate ORM which one to choose using hibernate.jdbc.use_get_generated_keys. Currently, we are trying to support all the queries generated by Hibernate ORM for the different cases.

With the Vert.x client, we usually have one way to get the id, so we can ignore the property and select the best option for each database.
@DavideD DavideD self-assigned this Apr 3, 2023
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 3, 2023
@DavideD
[hibernate#1553] Ignore hibernate.jdbc.use_get_generated_keys
ada24e8 
This property might make sense with JDBC. But the Vert.x client
is less flexible about the type of queries it needs to read the id.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 3, 2023
@DavideD
[hibernate#1553] Use the same identity generation strategy for all da…
f31cb08 
…tabases
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 3, 2023
@DavideD
[hibernate#1553] Remove ReactiveDialectWrapper and relative classes
94ed758
DavideD added a commit that referenced this issue Apr 3, 2023
@DavideD
[#1553] Ignore hibernate.jdbc.use_get_generated_keys
dade422 
This property might make sense with JDBC. But the Vert.x client
is less flexible about the type of queries it needs to read the id.
DavideD added a commit that referenced this issue Apr 3, 2023
@DavideD
[#1553] Use the same identity generation strategy for all databases
898963f
DavideD added a commit that referenced this issue Apr 3, 2023
@DavideD
[#1553] Remove ReactiveDialectWrapper and relative classes
0815b7f
@DavideD DavideD added this to the next milestone Apr 5, 2023
@DavideD
Copy link
Member Author

DavideD commented Apr 5, 2023

Done

@DavideD DavideD closed this as completed Apr 5, 2023
@DavideD
Copy link
Member Author

DavideD commented Apr 5, 2023

We are using the query generated when the property is set to false.
We are having a couple of issues with the queries generated by ORM that we will need to investigate if we want to remove the additional operations we do on the generated queries here.

Some of the related issues we've created on ORM:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
None yet
Projects
None yet
Milestone
2.0.0.Beta2
Development

No branches or pull requests
1 participant
@DavideD