Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: coverage workflow: pin to Python versions below 3.12 #918

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

jayaddison
Copy link
Collaborator

Follows-on-from #917 -- although in this case, I'm less confident that Python 3.12 is the cause of continuous integration failures.

Relates to #909.

@jayaddison
Copy link
Collaborator Author

jayaddison commented Oct 26, 2023

Merging this because doing so will resolve our continuous integration lint failures. However: I'm not sure why Python 3.12 should make any difference, or why black flake8 disagrees with the formatting of the reported f-strings with that version of Python. There may be a bug to report upstream to black flake8 here, but I'll do some more investigation first.

@jayaddison jayaddison merged commit 09d0ee8 into main Oct 26, 2023
16 checks passed
@jayaddison jayaddison deleted the ci/lint-workflow-python-version-range branch October 26, 2023 22:24
@jayaddison
Copy link
Collaborator Author

Merging this because doing so will resolve our continuous integration lint failures. However: I'm not sure why Python 3.12 should make any difference, or why black flake8 disagrees with the formatting of the reported f-strings with that version of Python. There may be a bug to report upstream to black flake8 here, but I'll do some more investigation first.

Nope; no bugreport required. We're using a version of flake8 - 6.0.0 - via pre-commit that doesn't yet support Python 3.12 - I'll upgrade that and remove the version pinning momentarily.

jayaddison added a commit that referenced this pull request Oct 26, 2023
… lower than 3.12 until #909 is resolved (#918)"

This reverts commit 09d0ee8.
strangetom pushed a commit to strangetom/recipe-scrapers that referenced this pull request Nov 12, 2023
hhursev pushed a commit that referenced this pull request Dec 6, 2023
…12 (#919)

* Revert "continuous integration: lint workflow: pin to Python versions lower than 3.12 until #909 is resolved (#918)"

This reverts commit 09d0ee8.

* pre-commit: update flake8 to v6.1.0 - providing support for Python 3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant