Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blocker: py3.12 upgrade requires updated release of pyrdfa3 #909

Closed
2 tasks done
jayaddison opened this issue Oct 19, 2023 · 2 comments
Closed
2 tasks done

blocker: py3.12 upgrade requires updated release of pyrdfa3 #909

jayaddison opened this issue Oct 19, 2023 · 2 comments
Labels
bug core-team-job

Comments

@jayaddison
Copy link
Collaborator

Pre-filing checks

  • I have searched for open issues that report the same problem
  • I have checked that the bug affects the latest version of the library

The URL of the recipe(s) that are not being scraped correctly
N/A

The results you expect to see
It should be possible to use recipe-scrapers with Python 3.12 (released 2023-10-02).

The results (including any Python error messages) that you are seeing
The imp module has been removed from Python 3.12 and this causes a ModuleNotFoundError in the dependency chain recipe-scrapers -> extruct -> pyrdfa3 -> imp. This can be seen in the build logs for #888.

The dependency on imp has already been removed from pyrdfa3; when an updated version of that library is available, this should become unblocked.
@jayaddison jayaddison pinned this issue Oct 19, 2023
@jknndy jknndy mentioned this issue Oct 26, 2023
Merged
jayaddison added a commit that referenced this issue Oct 26, 2023
@jayaddison
continuous integration: coverage workflow: pin to Python versions low…
4cede8e 
…er than 3.12 until #909 is resolved
@jayaddison jayaddison mentioned this issue Oct 26, 2023
Merged
jayaddison added a commit that referenced this issue Oct 26, 2023
@jayaddison
continuous integration: coverage workflow: pin to Python versions low…
edaea33 
…er than 3.12 until #909 is resolved (#917)
jayaddison added a commit that referenced this issue Oct 26, 2023
@jayaddison
continuous integration: lint workflow: pin to Python versions lower t…
90da114 
…han 3.12 until #909 is resolved
@jayaddison jayaddison mentioned this issue Oct 26, 2023
Merged
jayaddison added a commit that referenced this issue Oct 26, 2023
@jayaddison
continuous integration: lint workflow: pin to Python versions lower t…
09d0ee8 
…han 3.12 until #909 is resolved (#918)
jayaddison added a commit that referenced this issue Oct 26, 2023
@jayaddison
Revert "continuous integration: lint workflow: pin to Python versions…
5ef56b5 
… lower than 3.12 until #909 is resolved (#918)"

This reverts commit 09d0ee8.
@jayaddison jayaddison mentioned this issue Oct 26, 2023
Merged
strangetom pushed a commit to strangetom/recipe-scrapers that referenced this issue Nov 12, 2023
@jayaddison @strangetom
continuous integration: coverage workflow: pin to Python versions low…
63f585b 
…er than 3.12 until hhursev#909 is resolved (hhursev#917)
strangetom pushed a commit to strangetom/recipe-scrapers that referenced this issue Nov 12, 2023
@jayaddison @strangetom
continuous integration: lint workflow: pin to Python versions lower t…
4985e55 
…han 3.12 until hhursev#909 is resolved (hhursev#918)
hhursev pushed a commit that referenced this issue Dec 6, 2023
@jayaddison
pre-commit: update flake8 to v6.1.0 - providing support for Python 3.…
65f462e 
…12 (#919)

* Revert "continuous integration: lint workflow: pin to Python versions lower than 3.12 until #909 is resolved (#918)"

This reverts commit 09d0ee8.

* pre-commit: update flake8 to v6.1.0 - providing support for Python 3.12
@jayaddison
Copy link
Collaborator Author

An updated release of pyrdfa3 - version 3.6.2 - is available thanks to a new maintainer stepping in (see RDFLib/pyrdfa3#38 for details) for that project. This should unblock usage of this library on Python 3.12 - closing this issue.

@jayaddison jayaddison unpinned this issue Jan 22, 2024
@prrvchr
Copy link

prrvchr commented Jan 25, 2024 •
edited
Loading

I am happy that this allows you to move forward...
It is for the same reasons that I resolved to ensure the maintenance of pyRdfa3.

@jayaddison jayaddison mentioned this issue Oct 2, 2024
Merged
jayaddison added a commit that referenced this issue Oct 2, 2024
@jayaddison
Revert "continuous integration: coverage workflow: pin to Python vers…
c85a0ea 
…ions lower than 3.12 until #909 is resolved (#917)"

This reverts commit edaea33.
jayaddison added a commit that referenced this issue Oct 2, 2024
@jayaddison
Revert "continuous integration: coverage workflow: pin to Python vers…
681d080 
…ions lower than 3.12 until #909 is resolved (#917)" (#1264)

This reverts commit edaea33.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug core-team-job
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prrvchr @jayaddison