Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_nonnumeric_magnitudes #661

Closed
wants to merge 12 commits into from
Closed

Fix test_nonnumeric_magnitudes #661

wants to merge 12 commits into from

Commits on Jul 22, 2018

  1. Fix test_nonnumeric_magnituedes 

    Fixes hgrecco#659
    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    3af7a56 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from labrys/develop 

    Fix `test_nonnumeric_magnitudes`
    @labrys
    labrys authored Jul 22, 2018
    Configuration menu
    Copy the full SHA
    1db8a88 View commit details
    Browse the repository at this point in the history

  3. Fix comparison to None 

    Should be 'if cond is None:'
    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    05c0aa3 View commit details
    Browse the repository at this point in the history

  4. Fix test for membership 

    Should be 'not in'
    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    2b5dca8 View commit details
    Browse the repository at this point in the history

  5. Fix test for object identity 

    Should be 'is not'
    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    6eda2e7 View commit details
    Browse the repository at this point in the history

  6. Fix assertEquals is deprecated, use assertEqual

    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    6216a86 View commit details
    Browse the repository at this point in the history

  7. Fix old style class declaration, use new style (inherit from object)

    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    5edc90e View commit details
    Browse the repository at this point in the history

  8. Fix "min" is a python builtin and is being shadowed 

    Refactor min -> minimum
    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    1254fb3 View commit details
    Browse the repository at this point in the history

  9. Fix "max" is a python builtin and is being shadowed 

    Refactor max -> maximum
    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    8271a5c View commit details
    Browse the repository at this point in the history

  10. Fix bare except: 

    Bare except also catches unexpected events like memory errors,
interrupts,  system exit, and so on.  Prefer the specific exception
or `except Exception:` for general exceptions.  If you're sure
what you're doing, be explicit and write `except BaseException:`.
    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    ea2a116 View commit details
    Browse the repository at this point in the history

  11. Add coding magic comment

    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    b4a416b View commit details
    Browse the repository at this point in the history

  12. Fix trailing comma on bare tuple

    @labrys
    labrys committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    44351cf View commit details
    Browse the repository at this point in the history