Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for non-numeric magnitudes was using
assertRaises
incorrectly. While the context-manager form should be preferred, with the given style it should be passed the function to test, not the result of the function.While fixing this I found that
RuntimeError
was not being raised, instead aRuntimeWarning
was being issued. Sinceunittest.TestCase.assertWarns
was not added until Python 3.2 (see docs), I'm testing for the warning as recommended in the Python 2.7 docs.Fixes #659