Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added updated icons #89

Merged
merged 6 commits into from
Oct 10, 2022

Conversation

hcafaq
Copy link
Contributor

@hcafaq hcafaq commented Sep 28, 2022

Pull Request

Description

Describe your changes (or add ticket description) and add relevant screenshots

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

@github-actions
Copy link

Compiled a new version demo.

@heyabinanto heyabinanto self-requested a review September 28, 2022 11:48
@github-actions
Copy link

github-actions bot commented Sep 28, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 99.66% 869/872
🟢 Branches 93.01% 133/143
🟢 Functions 97.67% 42/43
🟢 Lines 99.75% 806/808
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / CarLocation.tsx
100% 100% 100% 100%
🟢
... / HeartDefault.tsx
100% 100% 100% 100%
🟢
... / HeartFilled.tsx
100% 100% 100% 100%
🟢
... / HeartHover.tsx
100% 100% 100% 100%
🟢
... / HeartPressed.tsx
100% 100% 100% 100%
🟢
... / HeartSelected.tsx
100% 100% 100% 100%
🟢
... / HeartSelectedHover.tsx
100% 100% 100% 100%
🟢
... / HeartSelectedPressed.tsx
100% 100% 100% 100%
🟢
... / Plus.tsx
100% 100% 100% 100%

Test suite run success

202 tests passing in 28 suites.

Report generated by 🧪jest coverage report action from a27f252

@esraltintas
Copy link
Contributor

Hey @hcafaq could you check the screenshot tests please

@hcafaq hcafaq requested a review from pappjanos October 4, 2022 19:45
@coveralls
Copy link

coveralls commented Oct 4, 2022

Pull Request Test Coverage Report for Build 3204099994

  • 33 of 33 (100.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 98.738%

Totals Coverage Status
Change from base Build 3182963275: 0.05%
Covered Lines: 806
Relevant Lines: 808

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Compiled a new version demo.

@hcafaq hcafaq marked this pull request as ready for review October 6, 2022 11:08
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Compiled a new version demo.

@hcafaq
Copy link
Contributor Author

hcafaq commented Oct 6, 2022

Hey @hcafaq could you check the screenshot tests please

done

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Compiled a new version demo.

@hcafaq hcafaq merged commit 5dad4af into main Oct 10, 2022
@hcafaq hcafaq deleted the feature/HEYUI-169-missing-icon-in-github branch October 10, 2022 07:56
derek-heycar pushed a commit that referenced this pull request Oct 10, 2022
# [2.1.0](v2.0.1...v2.1.0) (2022-10-10)

### Features

* **icons:** added updated icons ([#89](#89)) ([5dad4af](5dad4af))
@derek-heycar
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

hcafaq added a commit that referenced this pull request Oct 24, 2022
* feat(pill): added pill component

added a pill component alongside tests to display information

* fix(pill): fixed linting issue

fixed linting space issue in module.css file

* updates spaces

* test(pill): added screenshot tests for Pill

* fix(pill): updated constant height for pill to ignore multiline

* test(pill): update pill screenshot tests

* refactor(pill): updated font-weight to match the design

* test(pill): updated screenshot tests

* test(pill): updated sh tests

* test(pill): update sh

* test(pill): update sh

* test(pill): fix pill component screenshot test update problem

Fix pill component screenshot test update problem

* feat(icons): added updated icons (#89)

* feat(icons): added updated icons

* docs(icons): add car-location icons

* docs(icons): add hearts icons

* test(icons): add sh for icons

* style(icons): heart viewbox update

* chore(release): 2.1.0 [skip ci]

# [2.1.0](v2.0.1...v2.1.0) (2022-10-10)

### Features

* **icons:** added updated icons ([#89](#89)) ([5dad4af](5dad4af))

* chore: publish

 - @heycar-uikit/[email protected]
 - @heycar-uikit/[email protected]
 - @heycar-uikit/[email protected]

* feat(form-control): improve documentation part

* chore(release): 2.2.0 [skip ci]

# [2.2.0](v2.1.0...v2.2.0) (2022-10-11)

### Features

* **form-control:** improve documentation part ([ae8ff57](ae8ff57))

* feat(pill): added pill component

added a pill component alongside tests to display information

* fix(pill): fixed linting issue

fixed linting space issue in module.css file

* updates spaces

* test(pill): added screenshot tests for Pill

* fix(pill): updated constant height for pill to ignore multiline

* test(pill): update pill screenshot tests

* refactor(pill): updated font-weight to match the design

* test(pill): updated screenshot tests

* test(pill): updated sh tests

* test(pill): update sh

* test(pill): update sh

* test(pill): fix pill component screenshot test update problem

Fix pill component screenshot test update problem

* docs(pill): update default pill with icons

* test(pill): update pill sh

Co-authored-by: Oleksandr Zhukov <[email protected]>
Co-authored-by: Esra Altintas <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
derek-heycar pushed a commit that referenced this pull request Oct 25, 2022
# [2.9.0](v2.8.0...v2.9.0) (2022-10-25)

### Bug Fixes

* fixing typo from statuses to status ([#104](#104)) ([ba895ca](ba895ca))

### Features

* **pill:** added pill component ([#50](#50)) ([bcfd655](bcfd655)), closes [#89](#89) [#89](#89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants